chore: 🤖 public api as exports source-of-truth#845
Conversation
…istribute-esm-unbundled
…istribute-esm-unbundled
…-api-as-exports-generator-source-of-truth
|
Claude finished @punkbit's task in 1m 47s —— View job PR Review: chore: 🤖 public api as exports source-of-truth
Good direction overall — naming A couple of things need attention before merge: 🚨 Must Fix
💡 Suggestions (non-blocking)
🙌 Solid work on the documentation side — the Public API section in README and the backwards-compat examples are clear and useful. |
|
Claude finished @punkbit's task in 1m 41s —— View job PR Review: chore: 🤖 public api as exports source-of-truth
Solid cleanup — replacing 🚨 Must Fix
💡 Suggestions (non-blocking)
✅ Previous feedback addressed
Overall this is in great shape. The one must-fix is a cosmetic log line, not a functional issue. 🙌 |
|
Claude finished @punkbit's task in 48s —— View job PR Review: chore: 🤖 public api as exports source-of-truth
Great cleanup overall — the documentation additions are thorough and well-written, and the 🚨 Must Fix
💡 Suggestions (non-blocking)
✅ Previous feedback addressed
Solid PR — the public API story is much cleaner and the documentation is genuinely useful for maintainers. 🙌 |
|
Claude finished @punkbit's task in 39s —— View job PR Review: chore: 🤖 public api as exports source-of-truth
All previously flagged must-fix items have been addressed in this revision. Here's the summary: ✅ All previous feedback resolved
💡 Suggestion (non-blocking)
This PR is in great shape. The public API story is clean, the documentation is thorough, and the tooling is correctly wired up. 🙌 |
|
Claude finished @punkbit's task in 1m 14s —— View job PR Review: chore: 🤖 public api as exports source-of-truth
All feedback from previous review rounds has been addressed. Here's the final summary: ✅ All previous feedback resolved
💡 Remaining non-blocking notes (carry-forward, no action needed before merge)
This PR is ready to merge (pending the base branch swap from |
📚 Storybook Preview Deployed✅ Preview URL: https://click-n3kmh5kfl-clickhouse.vercel.app Built from commit: |
|
|
Why?
The team should have full control over the Public API to manage which resources are available for use in consumer applications. Previously, consumer applications had unrestricted access to internal resources, which is undesirable.
For example, third-party APIs like the primitive components provided by Radix UI were directly exposed, meaning that if those primitives were ever swapped out, any consumer applications depending on them would break due to tight coupling.
With these changes in place, core maintainers can now manage the Public API through a clear and friendlier interface.
🤖 On #841 merge, change base branch to main
How?
Preview?