Skip to content

[HDX] Add deep-review GitHub workflow#231

Merged
jordan-simonovski merged 2 commits into
mainfrom
warren/HDX-deep-review-workflow
Jun 27, 2026
Merged

[HDX] Add deep-review GitHub workflow#231
jordan-simonovski merged 2 commits into
mainfrom
warren/HDX-deep-review-workflow

Conversation

@wrn14897

@wrn14897 wrn14897 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

What

Ports the multi-agent PR review from hyperdx-ee into this Helm charts repo, adapted for a Helm/YAML codebase.

New workflow

  • .github/workflows/deep-review.yml — runs EveryInc/compound-engineering-plugin's ce-code-review skill on every non-draft PR (and via workflow_dispatch). Fans out to ~6–13 reviewer sub-agents and posts a single sticky <!-- deep-review --> findings comment. The prompt and the P0–P3 severity rubric are retuned for Helm changes (template render failures, malformed manifests, missing helm-unittest coverage, values defaults, etc.) rather than the EE's TS/Node framing.
  • .claude/settings.json — committed Bash allowlist (helm template/lint/dependency build) used as the project setting source. settings.local.json stays gitignored.

Adaptations from hyperdx-ee

  • Dropped the "Upstream merge for" PR-title skip (no OSS-sync flow in this repo); kept the draft skip.
  • Severity rubric and reviewer guidance rewritten around Helm template correctness and AGENTS.md conventions.
  • Kept verbatim: fork-safe PR-head checkout, base-SHA fetch, adversarial PR-metadata sanitization (fence token + length caps), pinned plugin (compound-engineering-v3.6.1), jq double-unwrap extraction, and sticky-comment posting.

Note: the /just-fix-it auto-resolver (deep-resolve.yml) is intentionally left out for now and can be added in a follow-up.

Prerequisite

The ANTHROPIC_API_KEY secret must be configured on the repo (or org). It has been added.

Validation

  • deep-review.yml passes YAML parse; .claude/settings.json passes JSON parse.
  • pull_request_target / workflow_dispatch workflows only execute from the default branch, so this takes effect on PRs opened after merge (or via a manual dispatch once on main).

@wrn14897 wrn14897 requested a review from a team as a code owner June 26, 2026 23:02
@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4af44ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Port the multi-agent PR review system from hyperdx-ee, adapted for this
Helm charts repo.

- deep-review.yml: runs the EveryInc/compound-engineering-plugin
  ce-code-review skill on every non-draft PR, posting a sticky
  <!-- deep-review --> findings comment. Prompt and severity rubric are
  tuned for Helm template / values / helm-unittest changes.
- .claude/settings.json: committed Bash allowlist (helm template/lint/
  dependency build) used as the project-scope setting source.

Requires the ANTHROPIC_API_KEY secret to be configured.
@wrn14897 wrn14897 force-pushed the warren/HDX-deep-review-workflow branch from cca0179 to d75cd94 Compare June 26, 2026 23:12
@wrn14897 wrn14897 changed the title [HDX] Add deep-review and deep-resolve GitHub workflows [HDX] Add deep-review GitHub workflow Jun 26, 2026
@jordan-simonovski jordan-simonovski merged commit 905758f into main Jun 27, 2026
5 checks passed
@jordan-simonovski jordan-simonovski deleted the warren/HDX-deep-review-workflow branch June 27, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants