Open
Conversation
|
|
rschu1ze
reviewed
Mar 9, 2026
sirius/benchmark.sh
Outdated
| rm -rf sirius | ||
|
|
||
| # Build Sirius from your optimized fork | ||
| git clone --recurse-submodules -b clickbench https://github.com/sirius-db/sirius.git |
Member
There was a problem hiding this comment.
Does "optimized fork" mean a Sirius version that was tailored for ClickBench? If yes ... it would be nicer to test default Sirius instead.
Author
There was a problem hiding this comment.
Hi Robert,
The Sirius version used here is not tailored for ClickBench. The branch includes a few general optimizations that are also part of the default branch. To reduce confusion, we have updated the PR to use the latest dev branch and updated the numbers and scripts accordingly.
sirius/benchmark.sh
Outdated
| # Build Sirius | ||
| git clone --recurse-submodules https://github.com/sirius-db/sirius.git | ||
| # Ensure Pixi is in the PATH for the current script | ||
| export PATH="$HOME/.pixi/bin:$PATH" |
Member
There was a problem hiding this comment.
Did dependencies.sh not install pixi in the global environment? I think we can just assume that the package manager is available. Maybe rather do this?
if ! command -v pixi &> /dev/null; then
echo "Pixi not found."
exit
fi
ducndh
changed the title
…Add H100 result too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Sirius benchmark results and scripts:
Update the scripts to use pixi following the latest build instructions on Sirius repo
Update the results using the latest Sirius on both GH200 (Lambda) and p5.4xlarge (AWS)