fix(test): E2E#74
Merged
Merged
Conversation
Signed-off-by: Julio Jimenez <julio@julioj.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions CI workflow to avoid running E2E tests when required AWS/S3 secrets are not configured, preventing confusing failures on forks or repos without those secrets.
Changes:
- Added an
e2e_preflightjob to detect whetherTEST_S3_BUCKET,AWS_ACCESS_KEY_ID, andAWS_SECRET_ACCESS_KEYare configured. - Wired
test_e2eto depend one2e_preflightand run only when the preflight indicates secrets are present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.