Open
Conversation
* task(SDK-5520) - Release v3.9.0 Inaction and NestedObject support * task(SDK-5520) - Fixes a minor bump in nested object date ingestion * task(SDK-5520) - Fixes changelog date
Anush-Shand
requested review from
CTLalit,
akashvercetti and
piyush-kukadiya
and removed request for
akashvercetti and
piyush-kukadiya
📝 WalkthroughWalkthroughThis PR releases version 3.9.0 with support for nested objects in event and profile properties. It updates CleverTap Android SDK to 7.8.0 and iOS SDK to 7.5.0, adds native layer handling for nested Map and Array types, enhances recursive date conversion for nested structures, and introduces example app demonstrations of the nested properties feature. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Example App
participant Bridge as React Native Bridge
participant Native as Native Layer<br/>(CleverTapModuleImpl)
participant SDK as CleverTap SDK
App->>App: Build nested payload<br/>(set_userProfileWithNestedProperties)
App->>Bridge: recordEvent('Product Purchased',<br/>eventProps with nested objs)
Bridge->>Bridge: convertDateToEpochInProperties<br/>(recursive traversal)
Bridge->>Native: Read ReadableMap<br/>(including nested Maps/Arrays)
Native->>Native: Handle nested Map type<br/>via MapUtil.toMap()
Native->>Native: Handle nested Array type<br/>via ArrayUtil.toArray()
Native->>SDK: profileSet() / recordEvent()<br/>with nested objects
SDK->>SDK: Process nested structure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Anush-Shand
requested review from
Sonal-Kachare,
nishant-clevertap and
piyush-kukadiya
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/index.js (1)
1244-1268: Recursive date conversion looks correct but has inconsistent indentation.The nested object and array handling properly recurses to convert
Datevalues at any depth. However, the array branch (lines 257-264) uses extra indentation compared to the rest of the function body, which hurts readability.One edge-case note: arrays nested inside arrays are handled implicitly — an inner array item passes the
typeof item === 'object'check on line 260 and entersconvertDateToEpochInProperties, which works becauseObject.entrieson an array yields index-value pairs. Consider adding an explicitArray.isArray(item)branch for clarity and to avoid relying on this implicit behavior.♻️ Suggested improvement for explicit nested array handling
} else if (Array.isArray(value)) { - value.forEach((item, index) => { - if (Object.prototype.toString.call(item) === '[object Date]') { - value[index] = "$D_" + Math.floor(item.getTime() / 1000); - } else if (item !== null && typeof item === 'object') { - convertDateToEpochInProperties(item); - } - }); - } + value.forEach((item, index) => { + if (Object.prototype.toString.call(item) === '[object Date]') { + value[index] = "$D_" + Math.floor(item.getTime() / 1000); + } else if (Array.isArray(item)) { + // Recursively handle nested arrays + item.forEach((nestedItem, nestedIndex) => { + if (Object.prototype.toString.call(nestedItem) === '[object Date]') { + item[nestedIndex] = "$D_" + Math.floor(nestedItem.getTime() / 1000); + } else if (nestedItem !== null && typeof nestedItem === 'object') { + convertDateToEpochInProperties(nestedItem); + } + }); + } else if (item !== null && typeof item === 'object') { + convertDateToEpochInProperties(item); + } + }); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/index.js` around lines 1244 - 1268, The convertDateToEpochInProperties function works but its array branch has inconsistent indentation and should explicitly handle arrays nested inside arrays; reformat the Array.isArray(value) branch to match the function's indentation style and add an explicit Array.isArray(item) check inside the value.forEach loop (in function convertDateToEpochInProperties) so that when item is an array you call convertDateToEpochInProperties(item) directly instead of relying on Object.entries on arrays; ensure the rest of the recursive branches remain unchanged and preserve Date-to-"$D_" epoch conversion logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/index.js`:
- Around line 1244-1268: The convertDateToEpochInProperties function works but
its array branch has inconsistent indentation and should explicitly handle
arrays nested inside arrays; reformat the Array.isArray(value) branch to match
the function's indentation style and add an explicit Array.isArray(item) check
inside the value.forEach loop (in function convertDateToEpochInProperties) so
that when item is an array you call convertDateToEpochInProperties(item)
directly instead of relying on Object.entries on arrays; ensure the rest of the
recursive branches remain unchanged and preserve Date-to-"$D_" epoch conversion
logic.
akashvercetti
approved these changes
Feb 17, 2026
Sonal-Kachare
approved these changes
Feb 17, 2026
CTLalit
approved these changes
Feb 17, 2026
nishant-clevertap
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inaction and NestedObject support
task(SDK-5520) - Fixes a minor bump in nested object date ingestion
task(SDK-5520) - Fixes changelog date
https://wizrocket.atlassian.net/browse/SDK-5520
Summary by CodeRabbit
Release 3.9.0