You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmmmm, you know... Sorting does not exist if everyone try to be the first
That's indeed exaggerated:
it's not about making mods use the "!" symbol, but rather about solving the issue of loading order changes caused by mod naming.
In fact, some users, particularly those in China, often translate mods into Chinese, which disrupts the file order and frequently results in the loss of the "!" symbol.
This PR provides a sorting mechanism that prioritizes mod relationships over file names. The goal is to ensure consistent ordering across different naming conventions as satisfactorily as possible.
Just write it like ![prefix]translated name
So here's why this is useless:
The reason of 99% of coremods being coremods is, transforming. This come in two ways: ASM and Mixin.
You don't need dependency in ASM.
As for Mixin, I don't want to encourage Mixin into other coremods, and CleanMix won't need target class appeared to load mixins.
The main reason of class not found in coremod is mixin provider not loaded. But our Mixin comes with the loader. Next version will support FermiumBooter API too.
Just write it like So here's why this is useless:![prefix]translated name
The reason of 99% of coremods being coremods is, transforming. This come in two ways: ASM and Mixin.
You don't need dependency in ASM.
As for Mixin, I don't want to encourage Mixin into other coremods, and CleanMix won't need target class appeared to load mixins.
The main reason of class not found in coremod is mixin provider not loaded. But our Mixin comes with the loader. Next version will support FermiumBooter API too.
This is indeed unnecessary. Because when players encounter such issues, we only need to point them out. Renaming the files or adopting your suggested approach, such as placing the "!" symbol at the beginning, are both effective methods. When problems arise, we can resolve them easily and consistently communicate the solutions to the players. However, in reality, I hope to add this feature to address the issue, even though it is a very minor improvement. Of course, you can raise questions, such as whether it compromises compatibility, and we can continue to discuss it.
I do want to merge this commit. But with the race between each coremod try to take over sorting order, the sorting will only really work if no one re-inventing another way to do something same and make everyone else suffering from it.
So for now this should be in the bin, but if we can come with the term later may this commit merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before :

After :
