Upd. Contacts Encoder. Flow improvements.#816
Open
alexandergull wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #816 +/- ##
============================================
+ Coverage 26.57% 26.61% +0.04%
- Complexity 5676 5681 +5
============================================
Files 269 269
Lines 24258 24270 +12
============================================
+ Hits 6446 6460 +14
+ Misses 17812 17810 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WordPress ContactsEncoder AJAX response compilation to sanitize returned fields (notably comment and decoded_email) and adds PHPUnit coverage to validate the new sanitization behavior.
Changes:
- Override
ContactsEncoder::compileResponse()in the WP implementation to escapecommentand sanitizedecoded_emailviawp_kses_post. - Add a set of unit tests covering
compileResponse()behavior for allowed/blocked cases and HTML sanitization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/Cleantalk/ApbctWP/ContactsEncoder/ContactsEncoder.php |
Adds a WP-specific compileResponse() override that escapes/sanitizes returned response fields. |
tests/ApbctWP/ContactsEncoder/TestContactsEncoder.php |
Adds tests asserting compileResponse() output shape and sanitization results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
AntonV1211
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/50334