Added text files reader#116
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for opening “text-like” attachments (code/config/log files) in a lightbox, using Ace Editor for syntax highlighting, and includes a small date-formatting guard to avoid errors on missing timestamps.
Changes:
- Classify attachments as image vs text to decide whether to open in an image lightbox, text lightbox, or download.
- Add a text lightbox implementation that fetches the file content and renders it in Ace Editor.
- Guard date formatting against falsy inputs (but currently returns
undefined, see comments).
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| styles/doboard-widget.css | Adds new lightbox styles intended for text viewer (currently overrides existing image lightbox styles). |
| js/src/widget.js | Adds text-file detection + Ace-based text lightbox and routes clicks accordingly. |
| js/src/handlers.js | Updates formatToDotMonthDate to handle missing input (needs a safe default return). |
| dist/doboard-widget-bundle.js | Rebuilt bundle reflecting the above source/style changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veronika-tseleva-cleantalk
requested review from
AntonV1211,
Glomberg,
alexander-b-clean,
alexandergull and
svfcode
Glomberg
approved these changes
Jun 19, 2026
AntonV1211
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/50634