Skip to content

Fix #54: Fix comment handling after the first one #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-tet merged 1 commit into from
Mar 25, 2026
Merged

Fix #54: Fix comment handling after the first one #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/clayde/tasks/plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,6 @@ def run_update(issue_url: str, phase: str) -> None:
log.warning("%s during plan update #%d", label, number)
accumulate_cost(issue_url, e.cost_eur)
span.set_attribute("plan.update_status", "timeout" if isinstance(e, InvocationTimeoutError) else "limit")
update_issue_state(issue_url, {
"status": IssueStatus.INTERRUPTED,
"interrupted_phase": IssueStatus.PRELIMINARY_PLANNING if phase == "preliminary" else IssueStatus.PLANNING,
})
return

total_cost = pop_accumulated_cost(issue_url) + result.cost_eur
Expand All @@ -301,10 +297,6 @@ def run_update(issue_url: str, phase: str) -> None:
except ValueError as e:
log.error("[%s: %s] Failed to parse update plan response: %s", issue_ref(owner, repo, number), issue.title, e)
span.set_attribute("plan.update_status", "parse_error")
update_issue_state(issue_url, {
"status": IssueStatus.INTERRUPTED,
"interrupted_phase": IssueStatus.PRELIMINARY_PLANNING if phase == "preliminary" else IssueStatus.PLANNING,
})
return

if updated_plan:
Expand Down
4 changes: 2 additions & 2 deletions tests/test_tasks_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,8 @@ def test_usage_limit_accumulates_cost(self):
run_update("url", "preliminary")

mock_accum.assert_called_once_with("url", 0.30)
last_call = mock_update.call_args_list[-1]
assert last_call[0][1]["status"] == "interrupted"
# Status must NOT be changed — issue stays in awaiting_*_approval for retry
mock_update.assert_not_called()

def test_skips_when_no_new_comments(self):
old_comment = MagicMock()
Expand Down
Loading