Fix KeyError when implementing small issues#53
Merged
Conversation
Timeouts were misclassified as UsageLimitError, causing false "usage limit hit" log messages and — for CLI backend — losing all session state so retries started from scratch. This introduces InvocationTimeoutError as a separate exception and ensures conversation state is saved before the timeout propagates: - API backend: catch TimeoutError, save conversation + commit WIP - CLI backend: pre-generate session ID via --session-id and save it before subprocess.run, so it survives timeouts - Task files: catch InvocationTimeoutError with accurate log messages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Small issues go directly from preliminary plan approval to implementation, but implement.run unconditionally read issue_state["plan_comment_id"] which doesn't exist for small issues. Fall back to preliminary_comment_id. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implement.rununconditionally readissue_state["plan_comment_id"], which doesn't exist for small issues — onlypreliminary_comment_idis setissue_state.get("plan_comment_id") or issue_state["preliminary_comment_id"]so it falls back correctlyKeyError: 'plan_comment_id'Test plan
_prepare_implementation_contextusespreliminary_comment_idwhenplan_comment_idis absent🤖 Generated with Claude Code