Updating iosxe/show_aaa.py/ShowAAServers p1b regex for RADSEC port consideration#865
Open
kentonrussell wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Open
Updating iosxe/show_aaa.py/ShowAAServers p1b regex for RADSEC port consideration#865kentonrussell wants to merge 1 commit intoCiscoTestAutomation:mainfrom
kentonrussell wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Conversation
Taarini
requested changes
Jul 18, 2024
Contributor
Taarini
left a comment
Taarini
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Sorry about the delay in review.
Please add UT, your changes looks good, left a comment for you to address them.
|
|
||
| # RADIUS: id 9, priority 1, host 11.15.24.174, RADSEC-port 1812,hostname ISE-RAD | ||
| p1b = re.compile(r'(.*)\:\s+id\s+(?P<id>\d+)\,\s+priority\s+(?P<priority>(\d+))\,\s+host\s+(?P<host>(.*))\,\s*(RADSEC\-port\s*(?P<radsec_port>(\d+)))\,\s*hostname\s+(?P<hostname>(.*))$') | ||
| # RADIUS: id 9, priority 1, host 11.15.24.174, RADSEC[- ]port 1812,hostname ISE-RAD |
Contributor
There was a problem hiding this comment.
Please dont update the existing comment. Add a separate comment for the regex change made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding regex logic to include both RADSEC-port and RADSEC port as valid auth port values.
C9800 version 17.12.3 uses RADSEC port while current logic only identifies RADSEC-port.
Motivation and Context
This change is required to match RADSEC AAA servers on the C9800.
Impact (If any)
None at the moment.
Screenshots:
Checklist: