Open
Conversation
ChristianFeldmann
requested changes
Aug 1, 2018
libde265/CMakeLists.txt
Outdated
| INSTALL(TARGETS | ||
| #libaries | ||
| ${LIBDE265_LIBRARY_NAME} | ||
| LIBRARY DESTINATION "/usr/lib/x86_64-linux-gnu/" |
Owner
There was a problem hiding this comment.
Hmm is this the right way to do it? Is this true for all linux distributions or is there maybe a cmake way to do this?
Author
|
I tried to find out how to do that. I don't think there is a cmake way
short of testing for the name of the system. Though I did not spend long on
this. But since we are going to use snap, which is similar to a docker
container, but ubuntu 16.04 based it should be fine.
…On Wed, Aug 1, 2018 at 7:32 PM, Christian ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In libde265/CMakeLists.txt
<#4 (comment)>
:
> @@ -83,3 +83,12 @@ target_link_libraries(${LIBDE265_LIBRARY_NAME} ${CMAKE_THREAD_LIBS_INIT})
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")
SET_TARGET_PROPERTIES(${LIBDE265_LIBRARY_NAME} PROPERTIES COMPILE_FLAGS "-fPIC")
endif(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")
+
+if(UNIX)
+ # could not find out how to determin library install path platform independent. this is for ubuntu (16.04)
+ INSTALL(TARGETS
+ #libaries
+ ${LIBDE265_LIBRARY_NAME}
+ LIBRARY DESTINATION "/usr/lib/x86_64-linux-gnu/"
Hmm is this the right way to do it? Is this true for all linux
distributions or is there maybe a cmake way to do this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmzCJ3sMlug-QQDuKuzxbJeddHa8ANRks5uMeZIgaJpZM4Vqsl4>
.
|
which is used by flatpak build configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added option to cmake file to only build the lib
added install target for the lib, matching ubuntu 16.04