RFAI-04: Add revision endpoints and edit-before-approve flow by Chris0Jeky · Pull Request #1058 · Chris0Jeky/Taskdeck

Chris0Jeky · 2026-05-09T10:36:26Z

Summary

Add 3 proposal revision API endpoints (create/list/latest) as sub-resources on AutomationProposalsController, with EditorUserId derived from JWT claims
Create proposalRevisionsApi.ts frontend HTTP client with typed interfaces
Add edit-before-approve UI in PaperReviewView: Request edit opens an inline revision editor with reason tracking
Store full sorted proposal operation snapshots for edits, including multi-operation proposals
Harden revision editing against stale loads/saves, payload prop changes, string type coercion, invalid JSON, and apply/reject races while editing

Scope note

This PR stores and reviews revision payloads, but approval/execution still applies the original proposal operations. The remaining apply-revised-payload wiring is follow-up work before RFAI-04: Typed ProposalCompiler and revision-backed edit-before-approve flow #976 can be closed.

Test plan

9 backend integration tests for revision endpoints, including invalid RevisedPayload JSON returning ValidationError
5 frontend proposalRevisionsApi unit tests (create, list, latest, 404 handling, error rethrow)
frontend revision lifecycle/editor/view regressions: reparse on payload changes, preserve string field types, clear stale state on proposal switch, ignore stale saves, multi-op editable payload, and disable decisions while editing
dotnet test backend/tests/Taskdeck.Api.Tests/Taskdeck.Api.Tests.csproj -c Release --filter "FullyQualifiedName~ProposalRevisionApiTests"
npm run test -- --run src/tests/views/paper/review/ReviewRevisionEditor.spec.ts src/tests/composables/useProposalRevisions.spec.ts src/tests/views/paper/review/PaperReviewView.spec.ts
npm run typecheck

Expose IProposalRevisionService via three sub-resource endpoints on AutomationProposalsController. EditorUserId is derived from JWT claims.

Wire the "Request edit" action to open an inline revision editor that parses the operations payload into editable fields. Revision badge shows when edits exist. Composable manages revision lifecycle state.

…edit click The edit-before-approve flow now opens a revision editor instead of showing a toast stub. Update the test to verify the editor appears and add the proposalRevisionsApi mock so useProposalRevisions loads cleanly.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0280dea44a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… load errors - Guard onRequestEdit against non-PendingReview and expired proposals - Block editing for multi-operation proposals (not yet supported) - Surface loadRevisionState errors via toast instead of swallowing silently

…oints Rename {proposalId} to {id} in revision endpoint route templates to match the convention used by all other sub-resource routes in the controller. Add missing <summary> XML doc comments for consistency.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c8539295e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky · 2026-05-09T10:49:03Z

Adversarial Review Findings

Fixed in `3c853929`

Route parameter naming inconsistency (LOW): Revision endpoints used {proposalId} while all other sub-resource endpoints use {id}. Fixed to {id} for consistency.
Missing XML doc comments (LOW): All existing endpoints had <summary> comments; the three revision endpoints did not. Added.

Fixed in `0fe6bee0` (background agent)

No guard against editing non-pending/expired proposals (MED): onRequestEdit did not check proposal status before opening the editor. Fixed with status and expiry checks.
No guard against multi-operation proposals (MED): The editor only handles single-operation payloads but accepted multi-op proposals. Fixed with a toast guard.
Silent error swallowing in loadRevisionState (LOW): Catch block swallowed errors without feedback. Fixed to surface via toast.

Fixed in next push

Race condition in loadRevisionState (P2, from Codex review): Rapid proposal switching could cause a slow response for a previous proposal to overwrite revision state for the current proposal. Fixed with a generation counter that discards stale responses. Test added.

Assessed and acceptable

editablePayload uses only ops[0].parameters (P1, from Codex review): Valid for single-op proposals. Multi-op proposals are already blocked by the guard in 0fe6bee0. When multi-op editing is supported in the future, editablePayload will need to serialize the full operations array.
No MaxLength on CreateRevisionRequest.RevisedPayload (N/A): The domain entity ProposalRevision validates emptiness and caps Reason at 500 chars. No payload size cap is consistent with how Parameters works on ProposalOperation.

When users switch proposals quickly, a slow API response for a previous proposal could overwrite the revision state for the currently selected proposal. Add a monotonic generation counter that discards stale responses. Adds a test verifying stale loads are ignored.

gemini-code-assist

Code Review

This pull request introduces a proposal revision system, allowing users to modify automation proposals before they are approved. The implementation includes new backend endpoints for managing revisions, a frontend API client, a state management composable, and a revision editor component. Feedback indicates that the ReviewRevisionEditor component needs to reactively handle changes to the operationsPayload prop using a watch effect and the corresponding Vue import. Furthermore, the current logic for editablePayload in PaperReviewView is limited to the first operation of a proposal, which should be expanded to support multiple operations.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7016a46f2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

chatgpt-codex-connector

💡 Codex Review

Taskdeck/frontend/taskdeck-web/src/views/paper/PaperReviewView.vue

Lines 490 to 494 in 0055f51

    
             if (status === 'Approved') { 
        
               void handleExecuteProposal(p.id) 
        
               return 
        
             } 
        
             void handleApproveProposal(p.id)

Apply latest revision payload before approve/execute

After a user saves an edit, onApply still calls handleApproveProposal(p.id) / handleExecuteProposal(p.id) with only the proposal ID, so the execution path continues using the original proposal.Operations rather than the revised payload. In this commit, revisions are persisted and shown in the UI, but they are never wired into approval/execution, so users can believe they edited a proposal while production execution still runs the unedited operations.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Chris0Jeky added 6 commits May 9, 2026 11:34

Add proposal revision API endpoints (create/list/latest)

7707ddf

Expose IProposalRevisionService via three sub-resource endpoints on AutomationProposalsController. EditorUserId is derived from JWT claims.

Add integration tests for proposal revision endpoints

9ee89fe

Add proposalRevisionsApi frontend HTTP client

2b13ea0

Add edit-before-approve UI in PaperReviewView

a13b264

Wire the "Request edit" action to open an inline revision editor that parses the operations payload into editable fields. Revision badge shows when edits exist. Composable manages revision lifecycle state.

Add frontend tests for revision API and composable

c381daa

Copilot AI review requested due to automatic review settings May 9, 2026 10:36

github-project-automation Bot added this to Taskdeck Execution May 9, 2026

github-project-automation Bot moved this to Pending in Taskdeck Execution May 9, 2026

Copilot started reviewing on behalf of Chris0Jeky May 9, 2026 10:36 View session

chatgpt-codex-connector Bot reviewed May 9, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/views/paper/PaperReviewView.vue Outdated

Comment thread frontend/taskdeck-web/src/composables/useProposalRevisions.ts

Chris0Jeky added 2 commits May 9, 2026 11:43

Fix route parameter naming and add XML doc comments for revision endp…

3c85392

…oints Rename {proposalId} to {id} in revision endpoint route templates to match the convention used by all other sub-resource routes in the controller. Add missing <summary> XML doc comments for consistency.

chatgpt-codex-connector Bot reviewed May 9, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/views/paper/review/ReviewRevisionEditor.vue Outdated

Comment thread frontend/taskdeck-web/src/composables/useProposalRevisions.ts Outdated

gemini-code-assist Bot reviewed May 9, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/views/paper/review/ReviewRevisionEditor.vue

Comment thread frontend/taskdeck-web/src/views/paper/review/ReviewRevisionEditor.vue Outdated

Comment thread frontend/taskdeck-web/src/views/paper/PaperReviewView.vue

chatgpt-codex-connector Bot reviewed May 9, 2026

View reviewed changes

Comment thread frontend/taskdeck-web/src/views/paper/review/ReviewRevisionEditor.vue

Comment thread frontend/taskdeck-web/src/composables/useProposalRevisions.ts

Copilot AI reviewed May 9, 2026

View reviewed changes

Harden proposal revision editing

0055f51

chatgpt-codex-connector Bot reviewed May 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFAI-04: Add revision endpoints and edit-before-approve flow#1058

RFAI-04: Add revision endpoints and edit-before-approve flow#1058
Chris0Jeky wants to merge 10 commits intomainfrom
rfai-04/976-edit-before-approve

Chris0Jeky commented May 9, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Chris0Jeky commented May 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (status === 'Approved') {
	void handleExecuteProposal(p.id)
	return
	}
	void handleApproveProposal(p.id)

Conversation

Chris0Jeky commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope note

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Chris0Jeky commented May 9, 2026

Adversarial Review Findings

Fixed in 3c853929

Fixed in 0fe6bee0 (background agent)

Fixed in next push

Assessed and acceptable

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Chris0Jeky commented May 9, 2026 •

edited

Loading

Fixed in `3c853929`

Fixed in `0fe6bee0` (background agent)