Skip to content

Add nix flake and convert to modern pyproject#5

Open
patrickjeremic wants to merge 5 commits intomasterfrom
nix
Open

Add nix flake and convert to modern pyproject#5
patrickjeremic wants to merge 5 commits intomasterfrom
nix

Conversation

@patrickjeremic
Copy link

@patrickjeremic patrickjeremic commented Feb 11, 2026

Updates the project to a more modern pyproject.toml and add a nix flake to be used with chorusos-nix. This additionally auto formats the code.

Copy link

@vchong vchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have the formatting changes in a commit of its own

dependencies = [
"click>=8.0",
"imageio>=2.9",
"numpy>=1.26",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly also <2.0 unless you have fixed that problem.

Copy link
Author

@patrickjeremic patrickjeremic Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In uv.lock you can see numpy being at 2.2.6 and i confirmed both flows (read and write) with it. Not sure what was causing the issue outside of nix before

You're correct, running uv sync + uv run python xfer.py read in the nix shell doesn't seem to work. Just running nix run .#default seems to run successfully. Seems to be something off with the python deps still.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted the project to uv2nix (https://pyproject-nix.github.io/uv2nix/templates.html) and it now covers all potential paths (Running python xfer.py, uv run python xfer.py and xfer in the dev shell, where xfer is just a wrapper to the xfer.py file). I also confirmed the stand alone binary to work. I didn't see any issues with the new numpy version interestingly.

@patrickjeremic patrickjeremic force-pushed the nix branch 2 times, most recently from 1a0e79d to bfd8a98 Compare February 12, 2026 16:22
@patrickjeremic
Copy link
Author

Thanks for the reviews, i cleaned up the commits further and split up the formatting into a seperate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants