Add nix flake and convert to modern pyproject#5
Add nix flake and convert to modern pyproject#5patrickjeremic wants to merge 5 commits intomasterfrom
Conversation
vchong
left a comment
There was a problem hiding this comment.
would be nice to have the formatting changes in a commit of its own
| dependencies = [ | ||
| "click>=8.0", | ||
| "imageio>=2.9", | ||
| "numpy>=1.26", |
There was a problem hiding this comment.
Possibly also <2.0 unless you have fixed that problem.
There was a problem hiding this comment.
In uv.lock you can see numpy being at 2.2.6 and i confirmed both flows (read and write) with it. Not sure what was causing the issue outside of nix before
You're correct, running uv sync + uv run python xfer.py read in the nix shell doesn't seem to work. Just running nix run .#default seems to run successfully. Seems to be something off with the python deps still.
There was a problem hiding this comment.
I converted the project to uv2nix (https://pyproject-nix.github.io/uv2nix/templates.html) and it now covers all potential paths (Running python xfer.py, uv run python xfer.py and xfer in the dev shell, where xfer is just a wrapper to the xfer.py file). I also confirmed the stand alone binary to work. I didn't see any issues with the new numpy version interestingly.
1a0e79d to
bfd8a98
Compare
|
Thanks for the reviews, i cleaned up the commits further and split up the formatting into a seperate commit. |
Updates the project to a more modern
pyproject.tomland add a nix flake to be used with chorusos-nix. This additionally auto formats the code.