Fix: moving rulesets to bottom_of_folder within same folder via REST …#907
Open
hadu-iteratio wants to merge 1 commit intoCheckmk:masterfrom
Open
Fix: moving rulesets to bottom_of_folder within same folder via REST …#907hadu-iteratio wants to merge 1 commit intoCheckmk:masterfrom
hadu-iteratio wants to merge 1 commit intoCheckmk:masterfrom
Conversation
|
Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days. This pull request will be closed due to inactivity after 60 days, if no action is taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…API failed
When attempting to reorder rules within the same folder using the REST API, the position value bottom_of_folder did not behave as expected. Although the API returned a success response (HTTP 200), the rule order remained unchanged. In contrast, top_of_folder worked correctly.
The BOTTOM sentinel is now resolved to the correct target index (end of the list) before calling get_index_for_move(). This ensures consistent handling while keeping the existing logic structure intact.
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.