Add environments list API (AST-129883) #1415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx-ronit-steinberg
requested review from
cx-anjali-deore,
cx-anurag-dalke and
cx-umesh-waghode
as code owners
|
Great job! No new security vulnerabilities introduced in this pull request |
cx-umesh-waghode
requested changes
Jan 26, 2026
| @@ -0,0 +1,45 @@ | |||
| package commandutils | |||
Contributor
There was a problem hiding this comment.
All these methods are in root.go and mainly used inside command implementations. Do we need this redundant globally available?
| triageGetStatesCmd := triageGetStatesSubCommand(customStatesWrapper, featureFlagsWrapper) | ||
|
|
||
| addFormatFlagToMultipleCommands( | ||
| commandutils.AddFormatFlagToMultipleCommands( |
Contributor
There was a problem hiding this comment.
Can we avoid changes to existing functionality when it can be avoided?
| {RiskManagementPathKey, RiskManagementPathEnv, "api/risk-management/projects/%s/results?scanID=%s"}, | ||
| {ConfigFilePathKey, ConfigFilePathEnv, ""}, | ||
| {RealtimeScannerPathKey, RealtimeScannerPathEnv, "api/realtime-scanner"}, | ||
| {DastEnvironmentsPathKey, DastEnvironmentsPathEnv, "api/dast/scans/environments"}, |
Contributor
There was a problem hiding this comment.
please add new entries at the end and keep them together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Add an API that allows searching for environments.
This will be used by the new DAST results panel in the extension for displaying DAST results.
Type of Change
Related Issues
https://checkmarx.atlassian.net/browse/AST-129883
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.