Skip to content

Add pixel-art logo to setup/init welcome message#32

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/add-ascii-logo-to-welcome-message
Draft

Add pixel-art logo to setup/init welcome message#32
Copilot wants to merge 4 commits intomainfrom
copilot/add-ascii-logo-to-welcome-message

Conversation

Copy link
Contributor

Copilot AI commented Mar 25, 2026

  • Inspect the current pixel-art welcome implementation and the last three commits on this branch
  • Confirm the new review feedback only requests making the setup welcome tests more readable with inline snapshots
  • Run the existing test suite to establish the current baseline before changing tests
  • Replace the current welcome-logo assertions in tests/setup.test.js with inline snapshot-based assertions
  • Re-run targeted setup tests to validate the updated snapshot coverage
  • Run final code review and security checks
  • Reply on the two new review comments with the addressing commit and screenshot link

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/96fcf2d5-9b7a-4503-aacc-4f5f5d9cdac1
Copilot AI changed the title [WIP] Add ASCII logo to init/setup script welcome message Add README-style ASCII logo to setup/init welcome message Mar 25, 2026
Copilot AI requested a review from ChangeHow March 25, 2026 09:37
@ChangeHow
Copy link
Owner

image @copilot 按照这个图生成 welcome message

Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/bfe1710a-bb2a-4949-9f4a-b18a8817da35
Copy link
Contributor Author

Copilot AI commented Mar 25, 2026

image @copilot 按照这个图生成 welcome message

已按图把 welcome message 改成像素风终端 banner,并补了对应的 focused test,提交在 fb92bec

截图:https://github.com/user-attachments/assets/baa86228-9827-42b5-a7e4-c80003a80df0

Copilot AI changed the title Add README-style ASCII logo to setup/init welcome message Add pixel-art logo to setup/init welcome message Mar 25, 2026
test("welcome message includes the ASCII suitup mark", () => {
const message = getWelcomeMessage();

expect(message).toContain("_____ _ __");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里用 inline snapshot,这样比较直观 @copilot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改成 inline snapshot,提交在 e4f5df3

截图:https://github.com/user-attachments/assets/baa86228-9827-42b5-a7e4-c80003a80df0


test("pixel-art welcome logo renders colored blocks and the status dot", () => {
const logo = getWelcomeLogo();
expect(logo).toContain("\u001b[38;5;255m");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot 改成 inlinesnapshot 啊,你这样我怎么想想是个什么玩意??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经换成更直观的 inline snapshot 了,渲染结果这边也改成去掉 ANSI 之后再 snapshot,提交在 e4f5df3

截图:https://github.com/user-attachments/assets/baa86228-9827-42b5-a7e4-c80003a80df0

Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ChangeHow/suitup/sessions/c4e7b073-da73-448f-9d4a-fed78817c3ea
Copilot AI requested a review from ChangeHow March 25, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants