feat(install): prompt for setup mode and run p10k configure after init#30
feat(install): prompt for setup mode and run p10k configure after init#30
Conversation
- Split monolithic tools.zsh + fzf.zsh into shared/tools/ modules (_loader.zsh, fzf.zsh, runtime.zsh, atuin.zsh, bun.zsh) - Add path-aware Ctrl-T widget in fzf.zsh - Add version-based cache invalidation in _loader.zsh - Widen perf.zsh timing table and add completion cache status line - Update gphu alias to use git branch --show-current - Migrate vim config and backups from ~/.config/suitup/ to ~/.config/zsh/ - Update src/steps, verify, clean, setup detection accordingly - Sync all tests and update AGENTS.md + README.md
- install.sh asks user to choose setup (interactive) or init (defaults) when no command is passed; direct args still bypass the prompt - init mode runs `p10k configure` after all steps complete - AGENTS.md: add Documentation Sync — REQUIRED section - README.md + README.zh-CN.md: sync curl behavior and init description
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the installation and configuration process by introducing a more guided and user-friendly installer prompt, alongside automating key post-installation steps like Powerlevel10k setup. It also brings a substantial internal refactoring of tool configurations into a modular, version-aware system, improving the overall maintainability and robustness of the Zsh environment. Comprehensive documentation updates ensure that all changes are clearly communicated and consistent across different language versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring of the Zsh tool configuration, moving from a single tools.zsh file to a modular structure with dedicated files for each tool (e.g., fzf, atuin, bun, runtime) and a centralized _loader.zsh for caching and loading logic. All configuration files are now consolidated under ~/.config/zsh/, removing the ~/.config/suitup/ directory. The install.sh script has been enhanced to offer an interactive choice between setup and init modes, and the init mode now automatically configures Powerlevel10k if needed. Documentation in both English and Chinese has been updated to reflect these changes, including a new guideline for documentation synchronization. The gphu alias was updated to use git branch --show-current. The only feedback is a suggestion to use Chinese full-width quotation marks for better typographical consistency in the Chinese README.
|
|
||
| - 若存在备份，优先恢复最近一次“非 suitup 版本”的 `~/.zshrc` / `~/.zshenv` | ||
| - 对仍与项目模板一致的文件，删除 `~/.config/zsh/` 与 `~/.config/suitup/` 下的 suitup 生成内容 | ||
| - 若存在备份，优先恢复最近一次"非 suitup 版本"的 `~/.zshrc` / `~/.zshenv` |
There was a problem hiding this comment.
For consistency with the typography used elsewhere in this document, it is recommended to use Chinese full-width quotation marks (“”) instead of English double quotes ("").
| - 若存在备份，优先恢复最近一次"非 suitup 版本"的 `~/.zshrc` / `~/.zshenv` | |
| - 若存在备份，优先恢复最近一次“非 suitup 版本”的 `~/.zshrc` / `~/.zshenv` |
1 participant
Summary
install.shnow asks the user to choose betweensetup(interactive, pick each step) andinit(non-interactive, recommended defaults) when invoked without arguments; passing a command directly still bypasses the promptinitmode now runsp10k configureat the end so users get their prompt theme set up immediatelyAGENTS.md: added Documentation Sync — REQUIRED section enforcing thatREADME.mdandREADME.zh-CN.mdmust always be updated togetherREADME.md+README.zh-CN.md: updated curl install behavior description andinitfeature list to reflect both changes aboveTesting
All 189 tests pass (
npm test).