Skip to content

feat(zsh): modularize tool configs into shared/tools/ directory#29

Merged
ChangeHow merged 1 commit intomainfrom
feat/modular-tool-configs
Mar 24, 2026
Merged

feat(zsh): modularize tool configs into shared/tools/ directory#29
ChangeHow merged 1 commit intomainfrom
feat/modular-tool-configs

Conversation

@ChangeHow
Copy link
Owner

Summary

  • Split monolithic shared/tools.zsh + shared/fzf.zsh into a shared/tools/ module directory (_loader.zsh, fzf.zsh, runtime.zsh, atuin.zsh, bun.zsh), with tools.zsh as a thin orchestrator
  • Add path-aware Ctrl-T widget (parses ~/, ./, relative paths from LBUFFER to scope fzf search)
  • Add version-based cache invalidation in _loader.zsh (replaces mtime-based)
  • Widen perf.zsh timing table (%-10s, 28 dashes) and add completion cache status line
  • Update gphu alias to use git branch --show-current
  • Migrate vim config and backups from ~/.config/suitup/ to ~/.config/zsh/ (deprecates ~/.config/suitup/)
  • Update src/steps/, verify.js, clean.js, setup.js to reflect new paths and structure
  • Sync all 6 test files; update AGENTS.md and README.md

Testing

All 189 tests pass (npm test).

- Split monolithic tools.zsh + fzf.zsh into shared/tools/ modules
  (_loader.zsh, fzf.zsh, runtime.zsh, atuin.zsh, bun.zsh)
- Add path-aware Ctrl-T widget in fzf.zsh
- Add version-based cache invalidation in _loader.zsh
- Widen perf.zsh timing table and add completion cache status line
- Update gphu alias to use git branch --show-current
- Migrate vim config and backups from ~/.config/suitup/ to ~/.config/zsh/
- Update src/steps, verify, clean, setup detection accordingly
- Sync all tests and update AGENTS.md + README.md
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Zsh configuration by introducing a modular structure for external tool integrations. This change aims to improve the organization, maintainability, and extensibility of the Zsh setup. It also enhances user experience with a more intelligent FZF file picker and more reliable caching for tool initialization, alongside a general cleanup of configuration paths.

Highlights

  • Zsh Tool Configuration Modularization: The monolithic shared/tools.zsh and shared/fzf.zsh files were refactored into a new shared/tools/ directory. This includes a _loader.zsh orchestrator and individual module files for fzf, runtime (zoxide, fnm), atuin, and bun, improving organization and maintainability.
  • Enhanced FZF Ctrl-T Widget: A new path-aware Ctrl-T widget was implemented for FZF, allowing it to parse ~/, ./, and relative paths from the Zsh buffer to scope file searches more intelligently.
  • Version-Based Cache Invalidation: The tool initialization caching mechanism was upgraded from mtime-based to version-based invalidation in _loader.zsh, ensuring tool init scripts are re-generated only when the tool's version changes.
  • Configuration Path Migration: Vim configuration and Zsh backup paths were migrated from ~/.config/suitup/ to ~/.config/zsh/, deprecating the suitup directory and centralizing Zsh-related configurations.
  • Performance Timing and Git Alias Improvements: The perf.zsh timing table was widened for better readability and now includes a completion cache status line. The gphu alias was updated to use git branch --show-current for more robust current branch detection.
  • Setup, Clean, and Verify Script Updates: All related JavaScript setup, clean, and verify scripts, along with documentation, were updated to reflect the new modular structure and migrated configuration paths.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Zsh tool configuration by modularizing tool-specific settings (fzf, atuin, zoxide, fnm, bun) into individual files under a new configs/shared/tools/ directory. A new _loader.zsh handles common loading logic and version-based caching, while configs/shared/tools.zsh now orchestrates the loading order. Documentation and various scripts (clean, setup, verify) have been updated to reflect this new structure and consolidate configuration under ~/.config/zsh/, removing the ~/.config/suitup/ path. Additionally, the gphu git alias was updated for reliability, and the performance report output was adjusted. A high-severity issue was identified in configs/shared/tools/fzf.zsh where non-POSIX shell syntax ([[ ... ]]) is used within an sh -c context, which could lead to errors on systems with basic /bin/sh implementations.

@ChangeHow ChangeHow merged commit 6a35372 into main Mar 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant