feat(zsh): modularize tool configs into shared/tools/ directory#29
feat(zsh): modularize tool configs into shared/tools/ directory#29
Conversation
- Split monolithic tools.zsh + fzf.zsh into shared/tools/ modules (_loader.zsh, fzf.zsh, runtime.zsh, atuin.zsh, bun.zsh) - Add path-aware Ctrl-T widget in fzf.zsh - Add version-based cache invalidation in _loader.zsh - Widen perf.zsh timing table and add completion cache status line - Update gphu alias to use git branch --show-current - Migrate vim config and backups from ~/.config/suitup/ to ~/.config/zsh/ - Update src/steps, verify, clean, setup detection accordingly - Sync all tests and update AGENTS.md + README.md
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Zsh configuration by introducing a modular structure for external tool integrations. This change aims to improve the organization, maintainability, and extensibility of the Zsh setup. It also enhances user experience with a more intelligent FZF file picker and more reliable caching for tool initialization, alongside a general cleanup of configuration paths. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Zsh tool configuration by modularizing tool-specific settings (fzf, atuin, zoxide, fnm, bun) into individual files under a new configs/shared/tools/ directory. A new _loader.zsh handles common loading logic and version-based caching, while configs/shared/tools.zsh now orchestrates the loading order. Documentation and various scripts (clean, setup, verify) have been updated to reflect this new structure and consolidate configuration under ~/.config/zsh/, removing the ~/.config/suitup/ path. Additionally, the gphu git alias was updated for reliability, and the performance report output was adjusted. A high-severity issue was identified in configs/shared/tools/fzf.zsh where non-POSIX shell syntax ([[ ... ]]) is used within an sh -c context, which could lead to errors on systems with basic /bin/sh implementations.
Summary
shared/tools.zsh+shared/fzf.zshinto ashared/tools/module directory (_loader.zsh,fzf.zsh,runtime.zsh,atuin.zsh,bun.zsh), withtools.zshas a thin orchestrator~/,./, relative paths from LBUFFER to scope fzf search)_loader.zsh(replaces mtime-based)perf.zshtiming table (%-10s, 28 dashes) and add completion cache status linegphualias to usegit branch --show-current~/.config/suitup/to~/.config/zsh/(deprecates~/.config/suitup/)src/steps/,verify.js,clean.js,setup.jsto reflect new paths and structureAGENTS.mdandREADME.mdTesting
All 189 tests pass (
npm test).