Skip to content

resolve comments

a40aba7
Select commit
Loading
Failed to load commit list.
Merged

fix(RPC): backport F3 finality resolution to eth V1 methods #6644

resolve comments
a40aba7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 5, 2026 in 1s

63.35% (-0.20%) compared to 967f83a

View this Pull Request on Codecov

63.35% (-0.20%) compared to 967f83a

Details

Codecov Report

❌ Patch coverage is 61.23348% with 88 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.35%. Comparing base (967f83a) to head (a40aba7).

Files with missing lines Patch % Lines
src/rpc/methods/eth.rs 61.90% 13 Missing and 27 partials ⚠️
src/rpc/methods/eth/tipset_resolver.rs 60.52% 28 Missing and 2 partials ⚠️
src/rpc/request.rs 12.50% 7 Missing ⚠️
src/rpc/methods/chain.rs 80.00% 3 Missing and 1 partial ⚠️
src/rpc/methods/state.rs 0.00% 0 Missing and 2 partials ⚠️
src/rpc/reflect/mod.rs 80.00% 1 Missing and 1 partial ⚠️
src/tool/subcommands/api_cmd.rs 0.00% 2 Missing ⚠️
src/rpc/client.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth/types.rs 76.04% <100.00%> (ø)
src/rpc/mod.rs 89.20% <ø> (ø)
src/tool/subcommands/api_cmd/test_snapshot.rs 85.31% <ø> (ø)
src/rpc/client.rs 46.37% <50.00%> (-0.04%) ⬇️
src/rpc/methods/state.rs 46.17% <0.00%> (ø)
src/rpc/reflect/mod.rs 69.45% <80.00%> (+0.80%) ⬆️
src/tool/subcommands/api_cmd.rs 0.00% <0.00%> (ø)
src/rpc/methods/chain.rs 52.55% <80.00%> (-0.29%) ⬇️
src/rpc/request.rs 41.37% <12.50%> (-18.63%) ⬇️
src/rpc/methods/eth/tipset_resolver.rs 60.52% <60.52%> (ø)
... and 1 more

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967f83a...a40aba7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.