Skip to content

fix: solana caip350 binary representation is the full 32 bytes #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
recxodus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: solana caip350 binary representation is the full 32 bytes #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eip155/caip350.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ Wallets and other software are expected to be able to fetch the extra informatio

[CAIP-2]: https://chainagnostic.org/CAIPs/caip-2
[CAIP-104]: https://chainagnostic.org/CAIPs/caip-104
[CAIP-350]: https://chainagnostic.org/CAIPs/caip-350
[EIP-55]: https://eips.ethereum.org/EIPS/eip-55
[EIP-155]: https://eips.ethereum.org/EIPS/eip-155
[EIP-2294]: https://eips.ethereum.org/EIPS/eip-2294
3 changes: 2 additions & 1 deletion solana/caip350.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ It is assumed wallets and other software will be able to differentiate between c

### Binary representation

To obtain the binary representation from the base58btc-encoded genesis blockhash, first truncate the base58btc-encoded text to its first 32 characters as described above and then decode it to raw bytes.
The binary representation is the 32 raw bytes obtained by base58btc-decoding the full 44-character genesis blockhash. The truncation described above applies only to the [CAIP-2] text form, never to the binary one: decoding the truncated 32-character string yields 23 bytes, which is neither a valid genesis blockhash nor a prefix of one [^1].

#### Text -> binary conversion

Expand Down Expand Up @@ -113,3 +113,4 @@ Wallets and other software are expected to be able to fetch the extra informatio

[CAIP-2]: https://chainagnostic.org/CAIPs/caip-2
[CAIP-104]: https://chainagnostic.org/CAIPs/caip-104
[CAIP-350]: https://chainagnostic.org/CAIPs/caip-350