[ENG-11580] Rebuild feature/pbs-26-13 on clean develop#11797
Closed
sh-andriy wants to merge 5 commits into
Closed
Conversation
…hed (CenterForOpenScience#11787) https://openscience.atlassian.net/browse/ENG-10365 Implement solution from analysis ticket. Here is the issue description and proposed solution: https://openscience.atlassian.net/browse/ENG-10851?focusedCommentId=121306 Call `archive_callback` only after all addons are archived
…eate-version bug (CenterForOpenScience#11788) add admin tool to recover preprints deleted by create-version bug
…ons (CenterForOpenScience#11786) ## Ticket https://openscience.atlassian.net/browse/ENG-11457 ## Purpose Draft registrations and usual registration should have at least 1 subject ## Changes Added validation
cslzchen
changed the title
cslzchen
approved these changes
Jul 5, 2026
cslzchen
left a comment
cslzchen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good 👍 and I going to back-up pbs-26-13 and reset it to your branch.
You can make a new PR to address my comment on a minor issue (dupe code).
Comment on lines
+139
to
+142
| draft_registration.subjects.add(SubjectFactory()) | ||
|
|
||
| with mock.patch('framework.celery_tasks.handlers.enqueue_task'): | ||
| draft_registration.subjects.add(SubjectFactory()) |
Collaborator
There was a problem hiding this comment.
Wondering if this is a leftover duplicate due to merge conflicts? I think we only need one.
Collaborator
|
After reset, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Changes
Side Effects
QE Notes
CE Notes
Documentation