[ENG-11025] V1 API for WB to V2 POC#11752
Open
Ostap-Zherebetskyi wants to merge 1 commit into
Open
Conversation
cslzchen
approved these changes
May 22, 2026
Collaborator
cslzchen
left a comment
There was a problem hiding this comment.
POC IMPL and JIRA Doc look good ⭐
There are still 3 test failures, but not a blocker since this PR is POC only.
=========================== short test summary info ============================
FAILED api_tests/base/test_views.py::TestApiBaseViews::test_view_classes_define_or_override_serializer_class - AssertionError: <class 'api.files.views.WaterbutlerAuthView'> should include serializer class or override get_serializer_class()
assert None
FAILED api_tests/base/test_views.py::TestApiBaseViews::test_view_classes_have_minimal_set_of_permissions_classes - AssertionError: <class 'api.files.views.WaterbutlerAuthView'> lacks the appropriate permission classes
assert <class 'api.base.permissions.TokenHasScope'> in [<class 'rest_framework.permissions.AllowAny'>]
+ where [<class 'rest_framework.permissions.AllowAny'>] = <class 'api.files.views.WaterbutlerAuthView'>.permission_classes
FAILED api_tests/base/test_views.py::TestApiBaseViews::test_view_classes_support_embeds - AssertionError: <class 'api.files.views.WaterbutlerAuthView'> lacks embed support
assert False
+ where False = hasattr(<class 'api.files.views.WaterbutlerAuthView'>, '_get_embed_partial')
==== 3 failed, 1606 passed, 5 skipped, 11972 warnings in 616.43s (0:10:16) =====
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
V1 API for WB to V2 POC
Changes
Side Effects
QE Notes
CE Notes
Documentation