Skip to content

[ENG-11025] V1 API for WB to V2 POC#11752

Open
Ostap-Zherebetskyi wants to merge 1 commit into
CenterForOpenScience:feature/legacy-code-removalfrom
Ostap-Zherebetskyi:poc/WB_migration
Open

[ENG-11025] V1 API for WB to V2 POC#11752
Ostap-Zherebetskyi wants to merge 1 commit into
CenterForOpenScience:feature/legacy-code-removalfrom
Ostap-Zherebetskyi:poc/WB_migration

Conversation

@Ostap-Zherebetskyi
Copy link
Copy Markdown
Collaborator

@Ostap-Zherebetskyi Ostap-Zherebetskyi commented May 22, 2026

Ticket

Purpose

V1 API for WB to V2 POC

Changes

Side Effects

QE Notes

CE Notes

Documentation

Copy link
Copy Markdown
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POC IMPL and JIRA Doc look good ⭐

There are still 3 test failures, but not a blocker since this PR is POC only.

=========================== short test summary info ============================
FAILED api_tests/base/test_views.py::TestApiBaseViews::test_view_classes_define_or_override_serializer_class - AssertionError: <class 'api.files.views.WaterbutlerAuthView'> should include serializer class or override get_serializer_class()
assert None
FAILED api_tests/base/test_views.py::TestApiBaseViews::test_view_classes_have_minimal_set_of_permissions_classes - AssertionError: <class 'api.files.views.WaterbutlerAuthView'> lacks the appropriate permission classes
assert <class 'api.base.permissions.TokenHasScope'> in [<class 'rest_framework.permissions.AllowAny'>]
 +  where [<class 'rest_framework.permissions.AllowAny'>] = <class 'api.files.views.WaterbutlerAuthView'>.permission_classes
FAILED api_tests/base/test_views.py::TestApiBaseViews::test_view_classes_support_embeds - AssertionError: <class 'api.files.views.WaterbutlerAuthView'> lacks embed support
assert False
 +  where False = hasattr(<class 'api.files.views.WaterbutlerAuthView'>, '_get_embed_partial')
==== 3 failed, 1606 passed, 5 skipped, 11972 warnings in 616.43s (0:10:16) =====

@cslzchen cslzchen marked this pull request as ready for review May 22, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants