Skip to content

[ENG-11256] Improve models structure#998

Open
nsemets wants to merge 8 commits into
CenterForOpenScience:feature/pbs-26-12from
nsemets:refactor/ENG-11256
Open

[ENG-11256] Improve models structure#998
nsemets wants to merge 8 commits into
CenterForOpenScience:feature/pbs-26-12from
nsemets:refactor/ENG-11256

Conversation

@nsemets

@nsemets nsemets commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

  1. Updated JSON:API models.
  2. Created reusable models.
  3. Split models for better readability.
  4. Update unit tests.

@nsemets nsemets requested a review from brianjgeiger May 27, 2026 14:43
Comment thread src/app/features/metadata/mappers/metadata.mapper.ts
Comment thread src/app/features/metadata/models/metadata-json-api.model.ts
Comment thread src/app/features/metadata/models/metadata-json-api.model.ts
@nsemets nsemets requested a review from omar-cos June 2, 2026 09:14
omar-cos
omar-cos previously approved these changes Jun 2, 2026
@nsemets nsemets changed the base branch from feature/pbs-26-9 to feature/pbs-26-12 June 22, 2026 12:22

@brianjgeiger brianjgeiger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants