[ENG-10829] Embargoed Registration — End Embargo Early Button Missing#982
[ENG-10829] Embargoed Registration — End Embargo Early Button Missing#982mkovalua wants to merge 7 commits into
Conversation
|
|
||
| statusTranslations = computed(() => { | ||
| const status = this.registry()?.status; | ||
| if (!status) { |
There was a problem hiding this comment.
I checked RegistryStatusEnum and the None value is "None" which is a truthy string. If that's the case then this wouldn't fix it. Could you double check?
There was a problem hiding this comment.
Hi @adlius, @Nazar690, I have updated
FYI: also not confident whether it is the best workflow, because not confident why 'None' may exists in database for registration that is needed to be embargoed
https://openscience.atlassian.net/browse/ENG-10829?focusedCommentId=119253
.
Maybe it is better to have another one workflow it is None , set another messages and do another UI workflow
https://openscience.atlassian.net/browse/ENG-10829?focusedCommentId=119253
, thanks
There was a problem hiding this comment.
@adlius Is it End embargo early right text for None status?
…y-statuses.component.ts Co-authored-by: nsemets <nsemets@exoft.net>
3 participants
Purpose
A subset of users are unable to end their embargoed registrations early. The "End Embargo Early" button is not appearing as expected, and users instead see the error text registry.overview.statuses.None.text on the registration overview page. This was previously resolved on a case-by-case basis by cloud engineering, but a permanent fix is now required.
Summary of Changes
if
registry.overview.statuses.None.textuse
registry.overview.endEmbargoas default for statusesScreenshot(s)
Side Effects
https://openscience.atlassian.net/browse/ENG-10829?focusedCommentId=119176
I suppose the solution may be to use registry.overview.endEmbargo as default if registry()?.status= None if None might be saved into database only for Embargoed registrations and not affect other status types. Otherwise it may be expected any other approach .
QA Notes