Keep Transcription Workspace On Screen#570
Merged
Merged
Conversation
…y the canvas-panel renderings, just keeps the workspace on screen.
Contributor
…y the canvas-panel renderings, just keeps the workspace on screen.
cubap
approved these changes
May 13, 2026
Member
cubap
left a comment
There was a problem hiding this comment.
tested with three things and it worked every time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #551 — a transcription line that boxes a tall region (a full un-split column, a tall decoration, etc.) was sizing
#imgTopso large that#transWorkspaceand the#imgBottompreview got pushed below the viewport. Body isoverflow: hidden, so the editor for the active line became unreachable.What changed
components/simple-transcription/index.js#updateImgTopMaxHeight()— caps#imgTop'smax-heighttoimageContainer.clientHeight - workspaceHeight - 40px, floored at 120px so we never collapse it on weird layouts.ResizeObserveron#transWorkspaceso the cap recomputes whenever tools open/close change the workspace's height.handleResize()now calls it as well, so viewport resizes pick up the new.image-containerheight (pinned at 100vh).renderCleanupso it disconnects on re-render / disconnect.No changes to canvas-panel rendering, zoom math, or the line-overlay alignment —
#imgTopkeeps its natural sizing fromadjustImages()and is only clamped at the top end viamax-height.