-
Notifications
You must be signed in to change notification settings - Fork 3
Vaulting #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Vaulting #436
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
5a0ff40
Hydrate from seed when fetch fails
cubap a71968c
runVaulttest
cubap de6307b
vault all fetches
cubap 36b1e91
Prefetch manifests before resolving canvases
cubap 2953bea
Use vault and prefetch manifests; enhance Vault
cubap ae6d1ec
Process IIIF resources and simplify ID normalization
cubap 4ec5596
Update interfaces/transcription/index.js
cubap c1e91b1
Update components/read-only-transcribe/index.js
cubap 973e4cf
Guard against empty URI in vault fetch to prevent unnecessary request…
Copilot 78bd3b0
Add prefetchManifests and prefetchCollections aliases with explicit t…
Copilot ab4db40
Eliminate N+1 fetches for embedded IIIF resources in vault (#439)
Copilot db8698c
Add explicit IIIF v2 prefixed types to resource set (#440)
Copilot b81735c
Update vault.js
cubap 5185901
Merge branch 'vaulting' of https://github.com/CenterForDigitalHumanit…
cubap 6ec5ad1
deprecate these
thehabes 71420f6
strip out TPEN.js and vault.js
cubap 489d059
Import vault in read-only-transcribe component
cubap de19429
This will work here (#443)
thehabes 32fc6ae
Early guard to avoid NPEs when this.#transcriptions cannot be used (#…
thehabes 01f8684
Address Issues 13-17 from static review: Fix vault consistency, error…
Copilot 2bafa53
Fix vault.js issues 8-11: Hoist constants, fix noCache, clone data, a…
cubap 45d2cb7
Update Conditionals to avoid NPEs (#447)
thehabes f6cad0d
Use vault.getWithFallback for fetching (#449)
cubap 3be1a6e
refactor manage columns to use vault (#450)
thehabes fb0e63d
hotfix for error messaging
thehabes a7439b9
No 'Auto Parse' for now
thehabes c13076e
No 'Auto Parse' for now
thehabes 3b115b2
Fix so CONTRIBUTOR users see the link into the /annotator interface
thehabes 122ff84
See transcription text in .transcription-input on the transcription i…
thehabes e51a257
Don't change @deprecated components
thehabes 250e76d
Changes while reviewing
thehabes dca5a14
Changes during review
thehabes 36c2e69
Changes during review
thehabes a79b190
zooming on view transcription interface
thehabes e0f47d7
Don't let view transcription interface be larger than the viewport an…
thehabes 67919cf
double right-click to zoom out
thehabes 3dd9bb1
double right-click to zoom out
thehabes be53732
small change for accessibility
thehabes a2236c5
small change for accessibility. Add some consistency around how thes…
thehabes 34c24ae
small change for accessibility. Add some consistency around how thes…
thehabes bd667ad
whoops make it prettier
thehabes 1eb3551
changes while reviewing
thehabes 8e1a280
remove references to elements that are no longer used
thehabes 11b30bb
Extra defensive for an extra chance to find the image
thehabes 89a1108
some cleanup
thehabes e54b9b3
Changes while reviewing
thehabes 7358d64
Changes while reviewing
thehabes 3cb3bf4
Changes while reviewing
thehabes fffa5d5
Changes while reviewing
thehabes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Auto Parse click handler immediately returns before the
tryblock, leaving a large unreachable block of code registered on every render. If the feature is intentionally disabled, it would be clearer to not register the listener (and/or hide/remove the button) behind a feature flag; otherwise remove the earlyreturnso the handler can run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah it's supposed to be dead like that for now until we want to use it.