Fix for rmt_GetLastErrorMessage do not report message for startup fail#265
Open
ntfshard wants to merge 1 commit intoCeltoys:mainfrom
Open
Fix for rmt_GetLastErrorMessage do not report message for startup fail#265ntfshard wants to merge 1 commit intoCeltoys:mainfrom
ntfshard wants to merge 1 commit intoCeltoys:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
This patch should resolve problem when initialization fails and error is not informative:
No error messageMain problem: if init fails, 'destructor' will call automatically (by macro) and TLS, which store msg will be destroyed.
Maybe better solution to move TLS destruction to
_rmt_DestroyGlobalInstancebut I have concern which tread will call it. Maybe same, maybe different. In other words it still can be a leak in case of different treads for init/fintMinor fix for closing socket if bind fails
Also fixed some style and grammar problems
You can verify this fix by running 2 instances of example