Conversation
rscipien
reviewed
Apr 13, 2026
| return bundle != EMPTY_BUNDLE; | ||
| } | ||
|
|
||
| private static boolean isNotInternal(final String bundleName) { |
Contributor
There was a problem hiding this comment.
I think this method should return false for DEFAULT_BUNDLE_FILE etc
But maybe we should consider create method for positive case isInternal?
And use isInternal in isNotInternal
Contributor
Author
There was a problem hiding this comment.
i think isNot internat reads better (more explicit) in
return isNotMetadataBundle(bundleName)
&& isNotInternal(bundleName)
&& loaderPath != null;
than
return isNotMetadataBundle(bundleName)
&& !isInternal(bundleName)
&& loaderPath != null;
Contributor
There was a problem hiding this comment.
if name will stay with not i think default case should return true
rscipien
approved these changes
Apr 14, 2026
lbownik
force-pushed
the
bundle_util_refactoring
branch
from
d44556a to
05497a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.