refact: streamlit 멀티 페이징 모듈 리펙토링 및 검증함수 추가#72
Merged
ParkGyeongTae merged 1 commit intomasterfrom Apr 28, 2025
Merged
Conversation
ehddnr301
approved these changes
Apr 27, 2025
Contributor
Author
@ehddnr301 저도 잘은 모르지만, 일반적으로는 custom validate 클래스 하나 안에 여러개의 validate 함수를 만들어서 가져다 쓰는 구조로 사용하지 않을까 싶습니다. 다만, 프로젝트가 점점점점 커져서 validate 함수가 엄~청 많아지면 해당 클래스도 분리하는 작업이 고려될만해 보여요! |
nonegom
approved these changes
Apr 28, 2025
Contributor
nonegom
left a comment
There was a problem hiding this comment.
👍: 저도 처음에 멀티 페이징 알려드렸을 때, 이렇게까지 모듈화를 생각하지는 못헀는데 좋은 것 같습니다!
Contributor
Author
|
@nonegom 오 다행입니당!!! 더 확장성있도록 고려해보겠습니다~~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
PR Checklist
reference) How to Code Review