PAINTROID-729 Refactor Converters#160
Open
Amit-Matth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the path serialization logic to eliminate external converters and centralize JSON logic within the models themselves.
PAINTROID-729
New Features and Enhancements
PathModelthat encapsulates both the native FlutterPathand its drawing action history.fromJsonandtoJsonlogic directly into thePathModelandPathActionclasses usingjson_serializable.PathModel(consistent withCatrobatImage) to ensure robust project loading and future-proofing.Refactorings and Bug Fixes
PathActionConverterandPathWithActionHistoryConverterclasses.PathCommandandLineCommandby usingexplicitToJson: true, allowing for cleaner nested object serialization.PathModel.fromJsonto correctly handle and migrate legacy projects saved without a version number.BrushToolandLineToolto utilize the improvedPathModellifecycle.Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.