Deprecated features fix by ross252004 · Pull Request #3033 · CatimaLoyalty/Android

ross252004 · 2026-02-21T16:11:08Z

This commit fixes the deprecated Locale features (deprecated Locale constructor is changed with Locale Builder). I plan to keep working on other deprecated features to replace them with working ones.
Also, one change to Russian translate was made because it was not translated correctly.

…ls.java (line 801 and line 807).

TheLastProject · 2026-02-21T18:00:02Z

Thanks, I'll try to have a look at this later, hopefully I have time next week.

For translation changes, please submit those through Weblate instead of by code as written in CONTRIBUTING.md. Using Weblate prevents merge conflicts in translations and ensures some basic quality checks are done.

ross252004 · 2026-02-24T18:54:27Z

Okay, got it. Will do.

- Fixed deprecated feature in build.gradle.kts app file called "resourceConfigigurations". Changed it to localeFilters feature. - Fixed a few others deprecated features but not all

ross252004 · 2026-02-24T19:48:49Z

I just pushed another commit. Here are the new fix ups:

Fixed deprecated feature in build.gradle.kts app file called "resourceConfigigurations". Changed it to localeFilters feature.
Fixed a few others deprecated features but not all

TheLastProject

Lots of different changes in this one MR, makes it hard to review honestly.

Please do one change per MR next time, so we can fix one thing and that fix isn't blocked by other changes and it's clear what is needed for what.

TheLastProject · 2026-02-26T18:44:48Z

app/src/main/java/protect/card_locker/MainActivity.kt

                }
                Intent.ACTION_SEND -> {
-                    intent.getParcelableExtra(Intent.EXTRA_STREAM)
+                    @Suppress("DEPRECATION") intent.getParcelableExtra(Intent.EXTRA_STREAM)


Please don't suppress deprecations, I want it to be loud in the logs because it's wrong and needs fixing :)

TheLastProject · 2026-02-26T18:45:04Z

app/src/main/java/protect/card_locker/MainActivity.kt

    private fun scaleScreen() {
        val displayMetrics = DisplayMetrics()
-        windowManager.defaultDisplay.getMetrics(displayMetrics)
+        @Suppress("DEPRECATION") windowManager.defaultDisplay.getMetrics(displayMetrics)


Please don't suppress deprecations, I want it to be loud in the logs because it's wrong and needs fixing :)

TheLastProject · 2026-02-26T18:45:25Z

app/src/main/res/values-ru/strings.xml

    <string name="importOptionFilesystemButton">Выбрать файл</string>
    <string name="about">О приложении</string>
-    <string name="app_license">Авторское лево свободного программного обеспечения, лицензия GPLv3+</string>
+    <string name="app_license">Программное обеспечение, распространяемое по лицензии Copyleft (GPLv3+).</string>


Please remove this commit. Language changes through Weblate only please.

TheLastProject · 2026-02-26T18:58:40Z

app/build.gradle.kts

+    androidResources {
+    localeFilters.addAll(listOf("ar", "be", "bg", "bn", "bn-rIN", "bs", "cs", "da", "de", "el-rGR", "en", "eo", "es", "es-rAR", "et", "fa", "fi", "fr", "gl", "he-rIL", "hi", "hr", "hu", "in-rID", "is", "it", "ja", "ko", "lt", "lv", "nb-rNO", "nl", "oc", "peo", "pl", "pt", "pt-rBR", "pt-rPT", "ro-rRO", "ru", "sk", "sl", "sr", "sv", "ta", "tr", "uk", "vi", "zh-rCN", "zh-rTW"))
+    }


Can't merge this as-is, as it also needs changes in the

Android/.scripts/locales.py

Lines 19 to 25 in 9121df1

sed = [

"sed",

"-i",

f"s/resourceConfigurations .*/resourceConfigurations += listOf({res})/",

"app/build.gradle.kts"

]

subprocess.run(sed, check=True)

script managing locale.

Please try to only fix one issue per MR, so that I can merge the things not blocked by other changes :)

I think it may be best to make a MR for just the locale fix, that's a small easy fix I can easily test and merge :)

TheLastProject · 2026-02-26T18:58:51Z

app/build.gradle.kts

            isMinifyEnabled = true
            proguardFiles(
-                getDefaultProguardFile("proguard-android.txt"),
+                getDefaultProguardFile("proguard-android-optimize.txt"),


What is this change for?

TheLastProject · 2026-02-26T19:04:38Z

app/build.gradle.kts


 plugins {
    alias(libs.plugins.com.android.application)
-    alias(libs.plugins.org.jetbrains.kotlin.android)


Is there a reason to remove the Kotlin plugin? Is this best practice? Where is this documented?

TheLastProject · 2026-02-26T19:04:45Z

gradle/libs.versions.toml

-com-android-application = { id = "com.android.application", version = "8.13.2" }
-org-jetbrains-kotlin-android = { id = "org.jetbrains.kotlin.android", version = "2.3.10" }


Is there a reason to remove the Kotlin plugin? Is this best practice? Where is this documented?

TheLastProject · 2026-02-26T19:04:49Z

build.gradle.kts


 plugins {
    alias(libs.plugins.com.android.application) apply false
-    alias(libs.plugins.org.jetbrains.kotlin.android) apply false


Is there a reason to remove the Kotlin plugin? Is this best practice? Where is this documented?

TheLastProject · 2026-02-26T19:05:11Z

gradle.properties

+android.defaults.buildfeatures.resvalues=true
+android.sdk.defaultTargetSdkToCompileSdkIfUnset=false
+android.enableAppCompileTimeRClass=false
+android.usesSdkInManifest.disallowed=false
+android.uniquePackageNames=false
+android.dependency.useConstraints=true
+android.r8.strictFullModeForKeepRules=false
+android.r8.optimizedResourceShrinking=false


Why all these changes?

TheLastProject · 2026-02-26T19:05:23Z

settings.gradle.kts

+plugins {
+    id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0"
+}


What is this and why is it necessary?

ross252004 added 2 commits February 20, 2026 23:53

Changed russian translation for string "app_license"

3cf7e6b

Changed deprecated Locale constructors with Builder() function in Uti…

0d5805d

…ls.java (line 801 and line 807).

- Migrated to built-in Kotlin

8dbc07c

- Fixed deprecated feature in build.gradle.kts app file called "resourceConfigigurations". Changed it to localeFilters feature. - Fixed a few others deprecated features but not all

TheLastProject requested changes Feb 26, 2026

View reviewed changes

TheLastProject mentioned this pull request Feb 26, 2026

Deprecated features fix2 #3037

Closed

TheLastProject marked this pull request as draft February 26, 2026 19:07

	sed = [
	"sed",
	"-i",
	f"s/resourceConfigurations .*/resourceConfigurations += listOf({res})/",
	"app/build.gradle.kts"
	]
	subprocess.run(sed, check=True)

		com-android-application = { id = "com.android.application", version = "8.13.2" }
		org-jetbrains-kotlin-android = { id = "org.jetbrains.kotlin.android", version = "2.3.10" }

Uh oh!

Conversation

ross252004 commented Feb 21, 2026

Uh oh!

TheLastProject commented Feb 21, 2026

Uh oh!

ross252004 commented Feb 24, 2026

Uh oh!

ross252004 commented Feb 24, 2026

Uh oh!

TheLastProject left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants