Added command line modes to launch forge into the lobby - #11577
Open
kenjitamura wants to merge 8 commits into
Open
Added command line modes to launch forge into the lobby#11577kenjitamura wants to merge 8 commits into
kenjitamura wants to merge 8 commits into
Conversation
…rom preferences before host and join launches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm setting up moonshine to run a forge server and several clients on the same machine. While setting it up I decided being able to use command line launch arguments to open to the lobby was something that'd be nice to have. Willing to clean this up if there are specific pointers and feelings aren't hurt if this is decided to be something the project doesn't want.
However, my experience with Java is practically non-existent with the closest being I've done some projects in C#.
This is admittedly all DeepSeek. I took dumps with async-profiler of the operations-
Host
Join
And asked it to make purely additive changes while preserving formatting of the original to add command line arguments as modes:
I tested locally and the only issues I've ran into are:
Output from deepseek and confirmed with diff view in vscode:
As a note I've found on my Ultramarine 44 x64 setup that each forge instance is showing 1.1GB ram usage with OpenJDK25. When I switched to OpenJ9 17 with sharedclasses mode each forge instance is using between 500 and 700MB.