Improve death-drain creature evaluation#11115
Open
Rauglothgor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When choosing creature removal targets, the AI can prefer a one-shot death trigger such as Serrated Scorpion over repeatable death-drain engines such as Zulaport Cutthroat, Blood Artist, and Cruel Celebrant.
Fixes #4171.
Minimal Fix
Creature evaluation now adds a small value bump for dies triggers that:
OtherinValidCard, andLoseLifeability.This keeps self-only death triggers such as Serrated Scorpion from receiving the same repeatable-engine value.
Validation
JAVA_HOME=/home/rauglothgor/.local/codex-tools/jdk17 /home/rauglothgor/.local/codex-tools/apache-maven-3.9.9/bin/mvn -pl forge-ai -am -DskipTests compileKnown Limits
This is not a general trigger evaluator. It only covers the narrow repeatable death-drain case described in the issue.
AI Assistance Disclosure
I used AI assistance to inspect the issue, trace the target-evaluation path, make the narrow change, and run validation. I reviewed the final diff and validation before opening this PR.