Conversation
Betree
force-pushed
the
refactor/move-to-gql-remove-redux
branch
3 times, most recently
from
023beb7 to
1a6845c
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a6845cce8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| error_message = Exception.message(exception) | ||
|
|
||
| conn | ||
| |> put_resp_content_type("application/json") | ||
| |> send_resp(200, build_graphql_error_response(error_message, "INTERNAL_ERROR")) |
There was a problem hiding this comment.
The rescue path forwards Exception.message/1 directly to GraphQL clients for unexpected errors, which can leak internal implementation details (database errors, validation internals, etc.) in production. INTERNAL_ERROR responses should return a generic client message and keep the detailed exception only in server logs.
Useful? React with 👍 / 👎.
Betree
force-pushed
the
refactor/move-to-gql-remove-redux
branch
from
1a6845c to
9c78884
Compare
Betree
force-pushed
the
refactor/move-to-gql-remove-redux
branch
7 times, most recently
from
8f10480 to
9e940d8
Compare
Betree
force-pushed
the
refactor/move-to-gql-remove-redux
branch
from
9e940d8 to
2debeb8
Compare
1 participant
No description provided.