fix: Add handling for missing VideoFormat on Linux#169
Open
meocoder31099 wants to merge 1 commit intoCapSoftware:mainfrom
Open
fix: Add handling for missing VideoFormat on Linux#169meocoder31099 wants to merge 1 commit intoCapSoftware:mainfrom
meocoder31099 wants to merge 1 commit intoCapSoftware:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current code, VideoFormat::RGBA is included in the list of output formats for the buffer
scap/src/capturer/engine/linux/mod.rs
Lines 213 to 222 in 92cabc5
but the case where VideoFormat is VideoFormat::RGBA is not handled
scap/src/capturer/engine/linux/mod.rs
Lines 136 to 164 in 92cabc5
This PR will fix it.
Summary by CodeRabbit