Skip to content

fix: prevent mask coverage gap during adjacent segment transitions #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamJBurns wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent mask coverage gap during adjacent segment transitions #1631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1354425
Fix for #1619
AdamJBurns Feb 24, 2026
7c69bfd
fix: use small epsilon for adjacency detection instead of fade_duration
AdamJBurns Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions crates/rendering/src/mask.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ pub fn interpolate_masks(
) -> Vec<PreparedMask> {
let mut prepared = Vec::new();

for segment in segments.iter().filter(|s| s.enabled) {
let enabled: Vec<&MaskSegment> = segments.iter().filter(|s| s.enabled).collect();

for (i, segment) in enabled.iter().enumerate() {
if frame_time < segment.start || frame_time > segment.end {
continue;
}
Expand All @@ -85,11 +87,32 @@ pub fn interpolate_masks(

let fade_duration = segment.fade_duration.max(0.0);
if fade_duration > 0.0 {
let adjacency_epsilon = 1e-3;

let adjacent_before = enabled
.iter()
.enumerate()
.any(|(j, other)| i != j && (segment.start - other.end).abs() < adjacency_epsilon);

let adjacent_after = enabled
.iter()
.enumerate()
.any(|(j, other)| i != j && (other.start - segment.end).abs() < adjacency_epsilon);

let time_since_start = (frame_time - segment.start).max(0.0);
let time_until_end = (segment.end - frame_time).max(0.0);

let fade_in = (time_since_start / fade_duration).min(1.0);
let fade_out = (time_until_end / fade_duration).min(1.0);
let fade_in = if adjacent_before {
1.0
} else {
(time_since_start / fade_duration).min(1.0)
};

let fade_out = if adjacent_after {
1.0
} else {
(time_until_end / fade_duration).min(1.0)
};

intensity *= fade_in * fade_out;
}
Expand Down