FIREFLY-1923: Fix inability to load large FITS tables#1981
Open
loitly wants to merge 1 commit into
Open
Conversation
- FITSTableReader: read columns via getColumn() instead of row-by-row getRow(), resolving type dispatch once per column instead of per cell - deg2pix: scrub NaN, clamp jp/jm to [0, nside) on both bounds (fixes left-shift overflow) - decimate_key/decimation stats: guard NaN and +/-Infinity, not just NaN FIREFLY-2047: Improve decimation handling of non-finite values - throw a clear error when a column has no finite values - exclude merged invalid-rows bucket from decimated output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.ipac.caltech.edu/browse/FIREFLY-1923
https://jira.ipac.caltech.edu/browse/FIREFLY-2047
FIREFLY-1923:
dispatch (getValAsObject(), nRow x nCol times) with getColumn() based
reads that resolve dispatch once per column instead.
FIREFLY-2047: Improve decimation handling of non-finite values
Test: https://firefly-1923-2047-nan-values.irsakubedev.ipac.caltech.edu/firefly/