Fix heap overflow in Razer SetupZones when KLM overlay expands grid#87
Open
NilsSei wants to merge 1 commit intoCalcProgrammer1:masterfrom
Open
Fix heap overflow in Razer SetupZones when KLM overlay expands grid#87NilsSei wants to merge 1 commit intoCalcProgrammer1:masterfrom
NilsSei wants to merge 1 commit intoCalcProgrammer1:masterfrom
Conversation
KLM overlay opcodes (INSERT_SHIFT_RIGHT etc.) can expand the key grid beyond the zone's declared height/width. GetKeyMap writes up to max(declared, actual)^2 entries but the map buffer was only allocated for declared^2, causing a heap overflow and crash on affected devices (e.g. Razer Blade 15 Late 2021 Advanced). Reallocate the map buffer to the actual KLM dimensions before calling GetKeyMap. new_map height/width intentionally remain at the declared values so the HID packet structure is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KLM overlay opcodes (INSERT_SHIFT_RIGHT etc.) can expand the key grid beyond the zone's declared height/width. GetKeyMap writes up to max(declared, actual)^2 entries but the map buffer was only allocated for declared^2, causing a heap overflow and crash on affected devices (e.g. Razer Blade 15 Late 2021 Advanced).
Reallocate the map buffer to the actual KLM dimensions before calling GetKeyMap. new_map height/width intentionally remain at the declared values so the HID packet structure is unchanged.