feat: responsive avatar image size#1077
Closed
xiaoxiyao wants to merge 1 commit intoCaiJimmy:masterfrom
Closed
Conversation
Owner
|
I think the current setting is good enough: the maximum size of the avatar is 150x150. The theme generates a single image of 300x300, which covers 1x and 2x. This PR will generate 3 images instead. |
|
It would be really nice to use plain SVG as site logo. The resize command ran against Hugo pipelines is hard coded and doesn't adhere to the disabled image processing in Hugo config. |
Contributor
Author
|
This is for loading smaller images on screens with low pixel ratios to improve loading speed. |
Owner
|
Sorry for the late reply, but I think I'll close this pull request for now, since it's no longer relevant (also because in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images#resolution_switching_same_size_different_resolutions