Merged
Conversation
qinglee
approved these changes
Apr 20, 2024
Member
qinglee
left a comment
There was a problem hiding this comment.
- 可以直接用
\codepoint_str_generate:n,同时把expl3的版本警告提升一下 \tl_build_get_intermediate:NN比较新,我倾向于用\cs_if_exist_use:NTF判断后使用
686bcb6 to
c2e0b81
Compare
使用封装好的 \codepoint_str_generate:n {<codepoint>},2022-10-09 加入 l3kernel。
新命令 \tl_build_get_intermediate:NN 需要 l3kernel 2023-12-14;兼容旧版 expl3。
Member
Author
|
Rebase branch 顺便 squash commits,以包含 c4bd6b8 ,让我 fork 里的 CI 通过。(fork 里的 CI 由 push 触发、基于 commit/branch head,PR 里的 CI 由 pull_request 触发,基于虚拟的 merge commit。) |
c2e0b81 to
ca5d383
Compare
Contributor
审查结论代码变更合理,逻辑清晰。主要修改点: 1.
|
Member
Author
|
@Liam0205 AI 生成的评论,是否加个标记,如「本评论由 xx 生成,我已 review」,以示区分。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\char_to_utfviii_bytes:n改写为\codepoint_str_generate:n,后者需要 l3kernel 2022-10-09\tl_build_get:NN简单替换为\tl_build_get_intermediate:NN,后者需要 l3kernel 2023-12-14需要兼容旧版 l3kernel 吗?