Update Dockerfile to use non-root user#735
Merged
CarrotManMatt merged 6 commits intomainfrom Mar 25, 2026
Merged
Conversation
This follows standard security best practices to NOT run applications inside docker containers as the root user if possible Signed-off-by: Matt Norton <matt@carrotmanmatt.com>
CarrotManMatt
added
the
deployment
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CarrotManMatt
added
the
sync
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the container build to run the application as a non-root user in the final runtime image, aligning the Docker image with common container security best practices.
Changes:
- Create a dedicated
nonrootsystem user/group in the runtime stage and switch execution to that user. - Change ownership of
/appcontents when copying from the builder stage to match the non-root user. - Adjust the
uv syncinvocation in the builder stage (lock/frozen behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The dependencies should be synced with `--frozen` not `--locked` because they are already locked in the `uv.lock` file and the `pyproject.toml` does not need checking. See https://docs.astral.sh/uv/reference/cli/#uv-sync Signed-off-by: Matt Norton <matt@carrotmanmatt.com>
MattyTheHacker
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows standard security best practices to NOT run applications inside docker containers as the root user if possible