Increase allocated memory for timestamp index#807
Open
ShangzhiXu wants to merge 1 commit intoCOVESA:masterfrom
Open
Increase allocated memory for timestamp index#807ShangzhiXu wants to merge 1 commit intoCOVESA:masterfrom
ShangzhiXu wants to merge 1 commit intoCOVESA:masterfrom
Conversation
This was referenced Dec 26, 2025
Collaborator
|
Hi @ShangzhiXu |
Contributor
Author
|
cheers~ let me double check~ |
Contributor
Author
|
Hi there, sorry for the late reply, I've double checked and this bug is still reproducable on the current version, and the patch works on my side. It is actually that a off-by-one occurs due to some logic error, message_count = (uint32_t) (1 + end - begin); // lets assume message_count = a
timestamp_index = (TimestampIndex *) malloc(sizeof(TimestampIndex) * (message_count + 1)); // alloc: a + 1
...
timestamp_index[message_count + 1].num = timestamp_index[0].num; // visit timestamp_index[a + 1]Here we write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further fix #792