Skip to content

Switch to enumeration_defaults system.#6

Open
jamesrhester wants to merge 1 commit intoCOMCIFS:mainfrom
jamesrhester:add_enum_defaults
Open

Switch to enumeration_defaults system.#6
jamesrhester wants to merge 1 commit intoCOMCIFS:mainfrom
jamesrhester:add_enum_defaults

Conversation

@jamesrhester
Copy link
Copy Markdown
Collaborator

Use of enumeration_defaults requires enumeration.def_index_ids as the index list.

Also changed URL for this dictionary.

Enumeration_defaults required enumeration.def_index_ids as the
index list.

Also changed URL for this dictionary.
@vaitkus
Copy link
Copy Markdown
Collaborator

vaitkus commented Apr 9, 2026

Before merging this and the related PRs, I would first like to test the dictionary checking software used in GitHub actions to see if it at least does not generate false-positive warnings related to these changes. Hopefully, I will manage to do that over the weekend.

On a related note, the dictionary URI change is also addressed with PR #2, but so it might be better to merge that first.

Also, PR #3 adds some dictionary consistency checks (syntax for now) which would be useful to have in place before making any further changes to the template files.

@vaitkus
Copy link
Copy Markdown
Collaborator

vaitkus commented Apr 12, 2026

@jamesrhester I checked and the software in question currently indeed does not handle these attributes properly (mostly due to the 'Inherited' content type). I could make a quick and dirty fix that simply silences the errors, but if the merging could be delayed for a week or so, I would prepare a proper extension that would properly validate these attributes. Is it OK to delay these merges a bit?

@jamesrhester
Copy link
Copy Markdown
Collaborator Author

Yes, I will wait. As you can probably tell I'm planning to create the release branch very soon. After these are merged I think we'll be ready to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants