This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Open
Conversation
ishanrai05
force-pushed
the
shell_check
branch
3 times, most recently
from
0fa287c to
2075b1f
Compare
ishanrai05
force-pushed
the
shell_check
branch
3 times, most recently
from
ba32d7a to
5faddfb
Compare
This was referenced Jul 6, 2020
Merged
Contributor
|
@z4027163 can you please check this one too. I have gone through it once and looks like nothing has changed. @ishanrai05 has only made the shell scripts formatting proper with the normal conventions of the shell scripts so the shell lint doesn't fails and we have proper shell formatted scripts in our repo. |
Contributor
|
@z4027163 can you please have a look here so we can merge this to master? The bash files have been formatted as per proper standards and no changes have been done otherwise. |
Contributor
Author
|
Its good to go from my side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready
Description
Added github actions to check shell script sytax and linted shell scripts
Is it backward compatible (if not, which system it affects?)
Yes
External dependencies / deployment changes
No
Mention people to look at PRs
@sharad1126 @amaltaro