Updates to fix zoomcontrol Issue #1124#1200
Open
sei-vsarvepalli wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #1124 in the SSVC calculator UI by adjusting the stacking order of the zoom/scale slider so it can be interacted with (not covered by the graph layer) when using the Coordinator Triage model.
Changes:
- Added a higher
z-indexto the#zoomcontrolcontainer to ensure the vertical range input remains clickable/draggable above the rendered graph.
Comments suppressed due to low confidence (1)
docs/ssvc-calc/findex.html:152
altis not a valid/accessibility-relevant attribute for<input type="range">. Use an accessible name (e.g.,aria-label) so screen readers can announce the control consistently.
style="z-index:100">
<div class="d-none">🔍</div>
<input type="range" orient="vertical" alt="Zoom Graph"
max="100" min="0" value="100" title="Zoom Graph"
onchange="svgzoom(this)">
Contributor
Author
|
Also resolves the issue in #1198 - where there is a collision between div names if the strings are similar like "Supplier Cardinality" vs "Supplier Engagement" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution to #1124 for the publish website to get the right update.