change(inclusion request): add the user during transform#556
Conversation
# Conflicts: # cds_migrator_kit/rdm/records/load/load.py
add(ep migration): review step fix(ep migration): usage of uow
83fa570 to
e5c9909
Compare
palkerecsenyi
left a comment
palkerecsenyi
left a comment
There was a problem hiding this comment.
Looks good! I haven't reviewed the bash scripts but the python code looks good to me
| if len(self.ep_approval) > 3: | ||
| raise UnexpectedValue( | ||
| message="EP approval history has more/less than 2 entries", | ||
| message="EP approval history has more/less than 3 entries", |
There was a problem hiding this comment.
| message="EP approval history has more/less than 3 entries", | |
| message="EP approval history has more than 3 entries", |
| reviewing = next( | ||
| ( | ||
| item | ||
| for item in history | ||
| if item.get("status") == EP_APPROVAL_REVIEWING_STATUS | ||
| ), | ||
| None, | ||
| ) |
There was a problem hiding this comment.
is this for when it is referred for additional review?
There was a problem hiding this comment.
yes is this additional step
| self.waiting_entry.get("submitted_by"), "submitter" | ||
| ), | ||
| topic={"record": restricted_recid}, | ||
| expires_at=expires_at, |
There was a problem hiding this comment.
I think we decided not to have request expiry, at least for new approval requests. I'm presuming if you set an expiry date in the past it works without erroring? I guess it is good to migrate the expiry dates of old requests.
There was a problem hiding this comment.
we did for the live instance, for the past records I want to keep the date for completeness
| }, | ||
| "7c568753-550b-4b48-8d76-461181973100": { | ||
| # aleph | ||
| "label": "EP approval", # shown in UI buttons/headings |
There was a problem hiding this comment.
Just fyi, we now also add committee_name to these configs so the UI knows what the actual approving committee is called. But this is only needed for the UI.
e.g. "committee_name": "EP Board"
2e51422 to
73a888b
Compare
github-project-automation
Bot
moved this from In review 🔍
to To release 🤖
in Sprint Q3 2026 ☀️
3 participants
NOTE: I didnt tested yet