Allow SlimBrowse to support duration#1052
Closed
smoothquark wants to merge 7 commits intoCDrummond:masterfrom
Closed
Allow SlimBrowse to support duration#1052smoothquark wants to merge 7 commits intoCDrummond:masterfrom
smoothquark wants to merge 7 commits intoCDrummond:masterfrom
Conversation
SlimBrowse currently does not seem to support duration values passed by plugins to Material skin. This, together with a trial trivial change to LMS (LMS-Community/slimserver#1348) allows Material to display track duration and total duration. Works with lms-plugin-tidal and Spotty-Plugin.
Allows duration passed as a string by SlimBrowse (modified lms-plugin-tidal) to be parsed correctly.
Author
|
I have corrected the original commit to parse duration passed as a string. |
Owner
|
Change looks OK to me, but need to get LMS pull request merged first. |
Author
|
Indeed. Thank you. |
…on Line 4 Currently online albums do not show artist name(s) passed via SlimBrowse Line2 and instead show no. of tracks in Line 2. This commit shows online albums similar to release albums with artist names passed via Line2 in SlimBrowse in Line 2 and no. of tracks (+/- total duration) in Line 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlimBrowse currently does not seem to support duration values passed by plugins to Material skin. This, together with a trial trivial change to LMS (LMS-Community/slimserver#1348) allows Material to display track duration and total duration. Works with lms-plugin-tidal and Spotty-Plugin.
However, this commit is totally dependent on LMS passing the duration values via SlimBrowse, and would be useless without it.