Skip to content

Disable sync settings when no TaskServer is configured #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Om-34 wants to merge 1 commit into
base: main
Choose a base branch
from
+97 −32
Open

Disable sync settings when no TaskServer is configured #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions lib/app/modules/settings/controllers/settings_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ import 'package:taskwarrior/app/v3/db/task_database.dart';

class SettingsController extends GetxController {
RxBool isMovingDirectory = false.obs;
RxBool taskchampion = false.obs;
RxBool taskReplica = false.obs;
RxBool serverCertExists = false.obs;

Rx<SupportedLanguage> selectedLanguage = AppSettings.selectedLanguage.obs;
RxString baseDirectory = "".obs;
Expand Down Expand Up @@ -218,7 +221,6 @@ class SettingsController extends GetxController {
RxBool isSyncOnTaskCreateActivel = false.obs;
RxBool delaytask = false.obs;
RxBool change24hr = false.obs;
RxBool taskchampion = false.obs;
RxBool isDarkModeOn = false.obs;

void initDarkMode() {
Expand All @@ -227,15 +229,38 @@ class SettingsController extends GetxController {

@override
void onInit() async {
super.onInit();
baseDirectory.value = await getBaseDirectory();
initDarkMode();
// 1. Check status immediately
await updateSyncStatus();
// 2. Re-check status whenever the Profile changes
ever(Get.find<SplashController>().currentProfile, (_) async {
await updateSyncStatus();
});
}

Future<void> updateSyncStatus() async {
final SharedPreferences prefs = await SharedPreferences.getInstance();
// Load Sync Settings
isSyncOnStartActivel.value = prefs.getBool('sync-onStart') ?? false;
isSyncOnTaskCreateActivel.value =
prefs.getBool('sync-OnTaskCreate') ?? false;
delaytask.value = prefs.getBool('delaytask') ?? false;
change24hr.value = prefs.getBool('24hourformate') ?? false;
// Load Profile Modes
taskchampion.value = prefs.getBool('settings_taskc') ?? false;
initDarkMode();
baseDirectory.value = await getBaseDirectory();
super.onInit();
taskReplica.value = prefs.getBool('settings_taskr_repl') ?? false;
// Load Legacy Certs status safely
if (Get.isRegistered<HomeController>()) {
try {
serverCertExists.value =
Get.find<HomeController>().serverCertExists.value;
} catch (e) {
serverCertExists.value = false;
}
} else {
serverCertExists.value = false;
}
}
}
96 changes: 68 additions & 28 deletions lib/app/modules/settings/views/settings_page_body.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,39 +76,79 @@ class SettingsPageBody extends StatelessWidget {
context,
tColors,
[
Obx(
() => SettingsPageListTile(
title: SentenceManager(
currentLanguage: controller.selectedLanguage.value)
.sentences
.settingsPageSyncOnStartTitle,
subTitle: SentenceManager(
currentLanguage: controller.selectedLanguage.value)
.sentences
.settingsPageSyncOnStartDescription,
trailing: SettingsPageOnTaskStartListTileTrailing(
controller: controller,
Obx(() {
// 1. Check if TaskServer is configured
final bool isEnabled = controller.taskchampion.value;
// 2. Wrap in GestureDetector to handle clicks on disabled state
return GestureDetector(
onTap: !isEnabled
? () => ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text('Please configure a TaskServer first'),
backgroundColor: tColors.secondaryBackgroundColor),
)
: null,
child: Opacity(
// 3. Dim the UI if disabled
opacity: isEnabled ? 1.0 : 0.5,
child: AbsorbPointer(
// 4. Block interaction if disabled
absorbing: !isEnabled,
child: SettingsPageListTile(
title: SentenceManager(
currentLanguage:
controller.selectedLanguage.value)
.sentences
.settingsPageSyncOnStartTitle,
subTitle: SentenceManager(
currentLanguage:
controller.selectedLanguage.value)
.sentences
.settingsPageSyncOnStartDescription,
trailing: SettingsPageOnTaskStartListTileTrailing(
controller: controller,
),
),
),
),
),
),
);
}),
Divider(
height: 1,
color: tColors.primaryDisabledTextColor?.withOpacity(0.1)),
Obx(
() => SettingsPageListTile(
title: SentenceManager(
currentLanguage: controller.selectedLanguage.value)
.sentences
.settingsPageEnableSyncOnTaskCreateTitle,
subTitle: SentenceManager(
currentLanguage: controller.selectedLanguage.value)
.sentences
.settingsPageEnableSyncOnTaskCreateDescription,
trailing: SettingsPageOnTaskCreateListTileTrailing(
controller: controller,
Obx(() {
final bool isEnabled = controller.taskchampion.value;
return GestureDetector(
onTap: !isEnabled
? () => ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text('Please configure a TaskServer first'),
backgroundColor: tColors.secondaryBackgroundColor),
)
: null,
child: Opacity(
opacity: isEnabled ? 1.0 : 0.5,
child: AbsorbPointer(
absorbing: !isEnabled,
child: SettingsPageListTile(
title: SentenceManager(
currentLanguage:
controller.selectedLanguage.value)
.sentences
.settingsPageEnableSyncOnTaskCreateTitle,
subTitle: SentenceManager(
currentLanguage:
controller.selectedLanguage.value)
.sentences
.settingsPageEnableSyncOnTaskCreateDescription,
trailing: SettingsPageOnTaskCreateListTileTrailing(
controller: controller,
),
),
),
),
),
),
);
}),
],
),
const SizedBox(height: 16),
Expand Down