Skip to content

Comments

Add teletext pages and PID type tagging to JSON report output (#1399)#2137

Open
ananyaaa66 wants to merge 2 commits intoCCExtractor:masterfrom
ananyaaa66:master
Open

Add teletext pages and PID type tagging to JSON report output (#1399)#2137
ananyaaa66 wants to merge 2 commits intoCCExtractor:masterfrom
ananyaaa66:master

Conversation

@ananyaaa66
Copy link

Closes #1399

Summary:

  • Added "type" field to PID entries
  • Added "teletext_pages" array
  • Added helper in telxcc.c

This builds on the existing --report-format json infrastructure.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6f7ce27...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 6/7
DVD 3/3
DVR-MS 2/2
General 25/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 81/86
Teletext 21/21
WTV 13/13
XDS 34/34

Your PR breaks these cases:

  • ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2...
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
  • ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
  • ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...

Congratulations: Merging this PR would fix the following tests:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 6f7ce27...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 6/7
DVD 3/3
DVR-MS 2/2
General 25/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 81/86
Teletext 21/21
WTV 13/13
XDS 34/34

Your PR breaks these cases:

  • ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2...
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
  • ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
  • ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
  • ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...

Congratulations: Merging this PR would fix the following tests:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@ananyaaa66
Copy link
Author

Re: Regression test failures

I've investigated the 8 failing regression tests reported by the bot and confirmed they are not caused by this PR's changes. Here's the analysis:

All code changes are strictly inside the JSON report code path:

The additions in

params_dump.c
are inside

print_file_report_json()
, which is only invoked when --report-format json is passed

tlt_print_seen_pages_json()
in

telxcc.c
is a new standalone function only called from the JSON path

teletext.h
only adds the declaration for the above function
The failing tests don't use JSON output:

--autoprogram --out=srt --latin1 --quant 0
--autoprogram --out=ttxt --latin1 --ucla
--out=srt --latin1 --autoprogram
--startcreditstext variants
None of these commands pass --report-format json, so the new code is never executed during these tests.

All 22 GitHub Actions CI checks pass (Linux, Windows, Mac builds + formatting).

These appear to be pre-existing flaky tests on the sample platform. Could a maintainer confirm or trigger a re-run?

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PROPOSAL] - Structured data JSON output of ccextractor -out=report

2 participants